Repository navigation
Support no-compression method in converter - #443
Merged
Merged
Conversation
gigony
added
feature request
grlee77
reviewed
Nov 17, 2022
grlee77
left a comment
grlee77
left a comment
Contributor
There was a problem hiding this comment.
Added a minor suggestion to make the compression string case insensitive and raise an error on anything other than 'jpeg', 'raw' or 'none'.
gigony
force-pushed
the
support_raw_save
branch
2 times, most recently
from
November 17, 2022 05:26
4a0a684 to
c650f7d
Compare
If you want to use no compression method for your converted file,
you can set the compression method to None in the converter.
In CLI, you can use `--compression` option and set it to any string
except `jpeg`.
E.g,
cucim convert --tile-size 512 --overlap 0 --num-workers 12 \
--output-filename resize.tiff --compression RAW \
notebooks/input/TUPAC-TR-467.svs
The converter will then convert the file without any compression.
Signed-off-by: Gigon Bae <gbae@nvidia.com>
gigony
force-pushed
the
support_raw_save
branch
from
November 17, 2022 17:02
c650f7d to
73aea90
Compare
grlee77
approved these changes
Nov 18, 2022
grlee77
left a comment
grlee77
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me, thanks
Contributor
|
@gpucibot merge |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want to use no compression method for your converted file, you can set the compression method to None in the converter.
In CLI, you can use
--compressionoption and set it to any string exceptjpeg.E.g.,
The converter will then convert the file without any compression.
Need to update test cases once #433 is merged.
Signed-off-by: Gigon Bae gbae@nvidia.com