Repository navigation
Normalize whitespace. - #474
Merged
rapids-bot[bot] merged 4 commits intoApr 5, 2023
Merged
Conversation
ajschmidt8
previously approved these changes
Jan 10, 2023
Member
|
Issue ( #484 ) has been addressed in Also added labels to fix the label checker |
grlee77
approved these changes
Feb 17, 2023
Contributor
|
Thanks, @bdice |
raydouglass
approved these changes
Feb 17, 2023
Member
|
Toggling for CI |
Member
|
@gpucibot merge |
Contributor
|
@jakirkham, the Please re-comment this PR with |
Member
|
/merge |
jakirkham
reviewed
Apr 5, 2023
| + //BOOST_ASSERT(0 == ((std::size_t)ret % ::boost::container::dtl::alignment_of<T>::value)); | ||
| return static_cast<T*>(ret); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Think we want to keep this line. Otherwise the patch doesn't apply
Member
|
Looks like the style check doesn't like that change 😂 If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/cpp/cmake/deps/boost-header-only.patch b/cpp/cmake/deps/boost-header-only.patch
index e765790..96c0078 100644
--- a/cpp/cmake/deps/boost-header-only.patch
+++ b/cpp/cmake/deps/boost-header-only.patch
@@ -14,4 +14,3 @@ index 7da31f7..5816de7 100644
+ //BOOST_ASSERT(0 == ((std::size_t)ret % ::boost::container::dtl::alignment_of<T>::value));
return static_cast<T*>(ret);
}
- Maybe we can skip this file during style checking? |
jakirkham
reviewed
Apr 5, 2023
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
jakirkham
approved these changes
Apr 5, 2023
Member
|
Thanks all! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables pre-commit checks for normalizing whitespace (trimming trailing spaces) that I disabled in #471.
These pre-commit hooks existed prior to the GitHub Actions migration but they were not being enforced by CI style checks. I disabled them in #471 because enforcing them would have made the PR diff large.
The primary change is in
.pre-commit-config.yaml, and everything else was automatically fixed bypre-commit.