[benlansdell]

This PR fixes a small bug in hue color jitter, as described in Issue #490. In images of all gray, some or all pixels are set to black when they shouldn't be. Looking at the CUDA kernel, it seems like the issue lies on line 208 of cuda_kernel_source.py.

Currently in the kernel if s == 0 then it sets the whole output to zero. But HSV is only black if v == 0, not s. So line 208 is here changed to:

if (v == 0) {

First PR here, so let me know what else is needed! Thanks.

[rapids-bot]

Pull requests from external contributors require approval from a rapidsai organization member with write or admin permissions before CI can begin.

[grlee77]

Thanks, @benlansdell! This looks good to me.

cc @shekhardw for visibility

[jakirkham]

ok to test

[ajschmidt8]

/ok to test

[ajschmidt8]

CI will be fixed shortly once #492 merges.

[jakirkham]

/merge

[ajschmidt8]

/ok to test

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (8a66080) to head (1a49fac).
Report is 9 commits behind head on branch-23.02.

Additional details and impacted files

@@              Coverage Diff              @@
##           branch-23.02     #491   +/-   ##
=============================================
  Coverage         92.95%   92.95%           
=============================================
  Files               130      130           
  Lines              9775     9775           
=============================================
  Hits               9086     9086           
  Misses              689      689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ajschmidt8]

@jakirkham, @grlee77, there were some test failures for arm below. I don't know anything about cucim to determine if they're legit, but I restarted that job to see if they were transient regardless.

Just posting for awareness.

• https://github.com/rapidsai/cucim/actions/runs/4068397175/jobs/7007242415

[jakirkham]

Thanks AJ! 🙏

Yeah we are discussing this offline