[Metrics] Add device index to the GPU metrics - #33328
Conversation
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
|
Btw, any recommendation in e2e tests? In the unit test env, it is hard to test the real GPU usage because we don't have GPUs... should we add a single node release test? Or do we have the best practice testing GPU related code? |
|
Also, I used {{DeviceName}}.{{index}}, {{ip}}, but it looks like the legend is not that pretty. Is there other recommendation? |
|
RE legend, how about something like {{ip}}, gpu.{{index}}, {{DeviceName}} ? There seems to be 4 scenarios:
My considerations are:
|
| @@ -143,8 +143,8 @@ Ray exports a number of system metrics, which provide introspection into the sta | |||
| - `InstanceId` | |||
| - The number of CPU cores per node. | |||
| * - `ray_node_gpus_utilization` | |||
There was a problem hiding this comment.
Thanks for updating the rst files too
| "Total GPUs available on a ray node", | ||
| "percentage", | ||
| ["ip", "SessionName"], | ||
| ["ip", "SessionName", "GpuDeviceName", "GpuIndex"], |
There was a problem hiding this comment.
| ["ip", "SessionName", "GpuDeviceName", "GpuIndex"], | |
| ["ip", "SessionName", "GPUDeviceName", "GPUIndex"], |
Shall we capitalize in this way consistently?
There was a problem hiding this comment.
I am fine with that, but that will break the backward compatibility (since we documented these now... Not sure if we mentioned it is stable APIs).
I also found "ip" is not needed because we use Instance labels
There was a problem hiding this comment.
I won't address it in this PR. Maybe I will make a follow up to use the same convention everywhere if we agree backward compatibility is not a concern.
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Add device index and name to the GPU metrics. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Add device index and name to the GPU metrics. Signed-off-by: elliottower <elliot@elliottower.com>
Add device index and name to the GPU metrics. Signed-off-by: Jack He <jackhe2345@gmail.com>
Why are these changes needed?
Add device index and name to the GPU metrics.
The tags will be
{ip, GpuIndex, GpuDeviceName}Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.