Repository navigation
[scenario tests stability] Pipeline ClusterTopologyRefreshIT verification to fit the test timeout - #4713
Merged
uglide merged 2 commits intoAug 28, 2026
Conversation
The test writes one key per round trip while the fault-injection reshard+failover runs, then verified each key with a sequential exists() — another full round trip per key. Both phases scale with the action's duration and together exceed the 300s global test timeout whenever the action takes ~150s or more. Pipelined batches collapse verification to a few round trips, so the test time tracks the action duration alone.
Collaborator
Author
|
run scenario tests |
Contributor
Jedis Scenario Tests (RE 8.0.16)
Github Test Reporter by CTRF 💚 |
Contributor
Jedis Scenario Tests (RE 100.0.20)
Github Test Reporter by CTRF 💚 |
Contributor
Jedis Scenario Tests (RE 8.0.22)
Github Test Reporter by CTRF 💚 |
uglide
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline ClusterTopologyRefreshIT verification to fit the test timeout
What
Replaces
ClusterTopologyRefreshIT.testWithPool's sequential per-keyexists()verification loop with pipelined batches (500 keys persync()), keeping an exact per-key failure message.Why
The test writes one key per round trip while the fault-injection
reshard+failoversequence runs, then verified every key with a sequentialexists()— another full round trip per key. Both phases scale linearly with the action's duration, so the total test time is roughly twice the action duration and exceeds the 300 s global test timeout (junit-platform.properties) whenever the action takes ~150 s or more.The nightly scenario runs fail consistently on this:
Measured on the scheduled runs: a passing run spent 120 s in the action and 116 s verifying 2180 keys (237 s total, 79% of the budget); a failing run spent 174 s in the action, leaving the ~156 s verification no room.
With pipelined verification the phase collapses from
n × RTT(~2 minutes at ~3000 keys) to a few round trips, so the test time tracks the action duration alone.Notes
EXISTS key [key ...]form is not an option in cluster mode (cross-slot); the per-keyResponse<Boolean>also keeps the exact missing key in the failure message.Note
Low Risk
Test-only change to verification timing; no production client behavior is modified.
Overview
ClusterTopologyRefreshIT.testWithPoolno longer verifies written keys with a sequentialexists()per key. It batchesexists()through a pipeline,sync()ing every 500 keys, and still asserts each key with amissing key {i}message on failure.This shortens the post–fault-injection verification phase so nightly runs stay under the 300 s JUnit timeout when resharding/failover runs long and thousands of keys were written.
Reviewed by Cursor Bugbot for commit 511017c. Bugbot is set up for automated code reviews on this repo. Configure here.