Repository navigation
fix(executor): drop the stale shortestPath property-map enumeration pin (size 18) - #236
Conversation
The expression-form 42N56 rejection (property maps are not supported in the shortestPath() function) landed with its relate-front validate pins but without repinning this executor test, which still asserted the removed "the BFS ignores relationship property maps" behaviour — so the executor lib suite is red on main. The front pins own the rule; this test is the stale duplicate, so it is deleted. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Security review (security-review skill) Reviewed the single-file diff ( No issues found. Security review: ✅ no issues found |
| @@ -115,21 +115,3 @@ fn assert_shortest_null_bound(g: &Graph, bound: &str) { | |||
| "{bound}: the fast path searched for a null-bound end" | |||
| ); | |||
| } | |||
There was a problem hiding this comment.
[Low] Documentation: The module doc still advertises "a relationship property map that falls back to enumeration", but this change deletes the only test covering that case — and shortestPath() relationship properties are now rejected at validation (42N56), so there is no enumeration fallback to describe.
Why this matters: the file header now names a scenario no test in the file exercises and that the engine rejects, so a reader looks for coverage that does not exist.
Suggested fix: drop the property-map clause from the module doc (lines 1–3), keeping only "a bound end that fails its pattern".
|
Rust review (rust-reviewer skill, full review) The skill reviewed the full PR diff — one deletion of the stale executor test
Rust review: ✅ no issues found |
|
Stellar review (stellar-review skill) Round 2 · head No open issues. Stellar review: ✅ no issues found |
Oplane Security ReviewOplane reviewed this PR and did not identify any security requirements that need attention. Review the generated threat model. Change comment settings · Set up Oplane in your agent · Workflow guidance |
Spec-harness coverage — 🟡
Rerun |
Summary
Fix: removes one stale executor test that
mainis currently red on. The expression-form 42N56 rejection ("properties are not supported in the shortestPath() function") landed with its relate-front validate pins but without repinning this executor test, which still asserted the removed "the BFS ignores relationship property maps" behaviour.Changes
relationship_property_map_runs_on_enumerationfromrelate/relate-executor/src/exec/shortest_expression_tests.rs— a stale duplicate of a rule the front-side pins already own (shortest_path_relationship_properties_are_rejectedinrelate-front/src/validate/match_shape.rs).Verification
cargo test -p relate-executor --lib: 1487 passed, 0 failed (was 1487 + 1 failed on pristineorigin/mainat 3aa20bf, verified in a detached worktree).cargo fmt --all --checkclean;cargo clippy -p relate-executor --all-targets -- -D warningsclean.🤖 Generated with Claude Code