Skip to content

fix(executor): drop the stale shortestPath property-map enumeration pin (size 18) - #236

Merged
jexp merged 1 commit into
mainfrom
fix/shortest-props-stale-test
Nov 12, 2026
Merged

jexp merged 1 commit into
mainfrom
fix/shortest-props-stale-test

Conversation

@jexp

@jexp jexp commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix: removes one stale executor test that main is currently red on. The expression-form 42N56 rejection ("properties are not supported in the shortestPath() function") landed with its relate-front validate pins but without repinning this executor test, which still asserted the removed "the BFS ignores relationship property maps" behaviour.

Changes

  • Deleted relationship_property_map_runs_on_enumeration from relate/relate-executor/src/exec/shortest_expression_tests.rs — a stale duplicate of a rule the front-side pins already own (shortest_path_relationship_properties_are_rejected in relate-front/src/validate/match_shape.rs).

Verification

  • cargo test -p relate-executor --lib: 1487 passed, 0 failed (was 1487 + 1 failed on pristine origin/main at 3aa20bf, verified in a detached worktree).
  • cargo fmt --all --check clean; cargo clippy -p relate-executor --all-targets -- -D warnings clean.

🤖 Generated with Claude Code

The expression-form 42N56 rejection (property maps are not supported in
the shortestPath() function) landed with its relate-front validate pins
but without repinning this executor test, which still asserted the
removed "the BFS ignores relationship property maps" behaviour — so the
executor lib suite is red on main. The front pins own the rule; this
test is the stale duplicate, so it is deleted.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Security review (security-review skill)

Reviewed the single-file diff (relate/relate-executor/src/exec/shortest_expression_tests.rs), which deletes one stale executor test asserting shortestPath behavior with relationship property maps. The change is test-only — no auth, input validation, storage, network, secrets, or dependency surface is touched. The deleted assertion duplicates a rule already enforced by shortest_path_relationship_properties_are_rejected in relate-front's match-shape validation, so no security-relevant behavior or coverage is lost.

No issues found.

Security review: ✅ no issues found

@@ -115,21 +115,3 @@ fn assert_shortest_null_bound(g: &Graph, bound: &str) {
"{bound}: the fast path searched for a null-bound end"
);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Low] Documentation: The module doc still advertises "a relationship property map that falls back to enumeration", but this change deletes the only test covering that case — and shortestPath() relationship properties are now rejected at validation (42N56), so there is no enumeration fallback to describe.

Why this matters: the file header now names a scenario no test in the file exercises and that the engine rejects, so a reader looks for coverage that does not exist.
Suggested fix: drop the property-map clause from the module doc (lines 1–3), keeping only "a bound end that fails its pattern".

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Rust review (rust-reviewer skill, full review)

The skill reviewed the full PR diff — one deletion of the stale executor test relationship_property_map_runs_on_enumeration. No Rust-scope findings: the test uses only helper APIs (Builder, counting_expands, exec_cypher, value) that stay used by the remaining tests, so there are no unused imports or dead code under -D warnings, and no ownership, lifetime, error-handling, unsafe, or idiom concerns arise from removing test-only code. The rejection rule it duplicated is still pinned by shortest_path_relationship_properties_are_rejected in relate-front.

  • Low — relate/relate-executor/src/exec/shortest_expression_tests.rs:1-3: the module doc still names the removed relationship-property-map fallback case; already covered by the existing inline comment from the previous round, not re-posted.

Rust review: ✅ no issues found

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Stellar review (stellar-review skill)

Round 2 · head d7042a59 · scope: 0/4 units (4 sealed from earlier rounds).

No open issues.

Stellar review: ✅ no issues found

@jexp
jexp marked this pull request as ready for review November 12, 2026 05:23
@oplane-bot

oplane-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

Oplane Security Review

Oplane reviewed this PR and did not identify any security requirements that need attention. Review the generated threat model.


Change comment settings · Set up Oplane in your agent · Workflow guidance

@jexp
jexp merged commit 9a98224 into main Nov 12, 2026
60 of 91 checks passed
@jexp
jexp deleted the fix/shortest-props-stale-test branch November 12, 2026 05:27
@github-actions

Copy link
Copy Markdown

Spec-harness coverage — 🟡

  • 🟡 spec coverage 99.40% — 201 genuine failures (0.60% of the executed scenarios)
  • scenarios run: 33639 (passed 33438, failed 201)
  • bands: 🟢 zero failures · 🟡 failure share ≤ 10% · 🔴 beyond (ADR-0482 §4 — the light never fails the build)
  • suite runtime: 45s
  • neo4j_expected_fail (not counted): 414
  • nondeterministic (not counted): 3
  • skipped (not counted): 2323
  • harness ref: 534014012290dbb179ba4d9d7a64c42523f6bfcc
failure category count
error-class-mismatch 44
result-mismatch 33
syntax-error 31
result-temporal-fidelity 29
notification-missing 19
missing-validation 13
semantic-error 10
type-error 10
other 9
setup-failed-syntax 3

Rerun spec-harness to refresh. Coverage below 100% never fails the build (ADR-0482 §4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant