Repository navigation
fix(tests): the ddl unit tests expect the constraint-equivalence token (size 6) - #245
Conversation
…n (size 6) The #239 rework renamed the constraint-equivalence condition to EquivalentConstraintAlreadyExists (the documented 22N65 token) and the CREATE CONSTRAINT gate in catalog_schema.rs emits it — but the re-squash that landed dropped ddl.rs from its declared file list, so its two unit tests kept asserting the index-equivalence token (22N70) the old path raised, and the executor suite went red on main. Restores the two assertions from the round that wrote them. Verified: cargo test -p relate-executor --lib — 1567 passed, 3 ignored, including exec::ddl; cargo fmt --all --check clean. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Security review (security-review skill) Analysed the single-file diff in No issues found. Security review: ✅ no issues found |
|
Stellar review (stellar-review skill) Round 1 · head Findings on context units (not on the current diff — summary only; night-shift backlog, never inline, never verdict blockers)
Stellar review: ✅ no issues found |
Oplane Security ReviewOplane reviewed this PR and did not identify any security requirements that need attention. Review the generated threat model. Change comment settings · Set up Oplane in your agent · Workflow guidance |
Classification
Test-expectation fix — restores assertions a re-squash dropped; no engine behaviour change.
What
The #239 rework renamed the constraint-equivalence condition to
EquivalentConstraintAlreadyExists(the documented22N65token) and theCREATE CONSTRAINTgate incatalog_schema.rsemits it. The re-squash that landed droppedddl.rsfrom its declared file list, so its two unit tests kept asserting the index-equivalence token (22N70) the old path raised, and the executor suite went red on main. This restores the two assertions from the round that wrote them — the same root cause and the same fix shape as #244 (the constraint-matrix rows).Verification
cargo test -p relate-executor --lib: 1567 passed, 3 ignored, includingexec::ddl(main: 2 failed)cargo fmt --all --checkclean🤖 Generated with Claude Code