Repository navigation
Conversation
…river, Literal operand spelling, static_arithmetic split (LABS-1345, LABS-810, LABS-759) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
|
||
| /// The arithmetic operators that raise a type error for *every* non-numeric, | ||
| /// non-null operand. `+` is deliberately excluded from the | ||
| /// [`ARITHMETIC_OPS`] set here: it is also string concatenation (`'a' + 1` → |
There was a problem hiding this comment.
[Low] Idiomatic Rust: the moved doc comment links to ARITHMETIC_OPS, which stayed private in static_types; the mirror case is static_types.rs:236, whose doc now links to is_failing_arithmetic_op after that item moved here.
Why this matters: both links resolved before the split, and rustdoc now reports unresolved link warnings for them (no CI job builds docs, so they land silently).
Suggested fix: reword to a plain reference (e.g. "the arithmetic-operator set in static_types"), or pub(super) the const and import it at the new home.
|
Rust review (rust-reviewer skill, full review) Full review of the The merged driver is behaviour-preserving: No issues found. Rust review: ✅ no issues found |
|
Security review (security-review skill) Analysed the No issues found. Security review: ✅ no issues found |
|
Stellar review (stellar-review skill) Round 1 · head New findings
Low findings — collapsed, no inline threads (ADR-0354); superseded by the next round's list
Stellar review: |
Oplane Security ReviewOplane reviewed this PR and did not identify any security requirements that need attention. Review the generated threat model. Change comment settings · Set up Oplane in your agent · Workflow guidance |
Spec-harness coverage — 🟡
Rerun |
| !items.is_empty() | ||
| && items | ||
| .iter() | ||
| .all(|e| static_literal_type(e).is_some_and(non_numeric_leaf_class)) |
There was a problem hiding this comment.
[Medium] structure (std-6): The new module borrows its literal-type vocabulary from static_types (its use super::static_types::{is_arithmetic_op, non_numeric_leaf_class, static_literal_type, unparen, StaticLitType} at lines
Suggested fix: Make the family one directional: move the shared literal-type vocabulary (StaticLitType, static_literal_type, unparen, non_numeric_leaf_class, is_arithmetic_op) into a base static_literals module that static_types, static_arithmetic, static_calls, static_reduce and dynamic impo
finding F-1-1
| // exactly as the self-capping walker this replaces did. | ||
| Err(_) => false, | ||
| Ok(()) => search.found, | ||
| } |
There was a problem hiding this comment.
[Medium] boundaries (std-5): This is a silent fallback over an invariant-bound Result: walk_expr_scoped's only error is the nesting-depth cap (every visitor method here returns Ok), and the battery that reaches this helper alre
Suggested fix: Mirror the sibling walks: let result = walk_expr_scoped(expr, &mut search); debug_assert!(result.is_ok(), "applies_arithmetic_to_var runs after the depth guard"); search.found (or propagate the typed error if the precondition cannot be guaranteed). Drop the 'over-deep defers to runtime' comment, w
finding F-1-2
|
Loadtest baselines comparison
Loadtest baseline comparisonFrozen baselines vs current reports; bands match the Status: warning Pairs: fraud-loadtest: compared (failing rows) · identity-loadtest: compared (failing rows) fraud-loadtest
Per-use-case p99 latency
identity-loadtest
Per-use-case p99 latency
|
|
Memory shape
Memory shapeStatus: ok All memory shapes held. 🟢 baseGiven: an empty relate serve, 1 integer properties on every node, text indexes 0, point indexes 0, range indexes 0, and a 32.00 MB logical ceiling. When: the base shape is loaded to 0 nodes and 0 relationships, then checkpointed. The child RSS is sampled. Then: the database holds those counts. The load finishes under the ceiling. Logical bytes, disk, attributed RSS, and the ratio stay inside the frozen boundaries. Baseline: logical 0.00 MB – 0.00 MB, disk 0.00 MB – 0.00 MB, attributed RSS 0.00 MB – 0.00 MB, ratio 0.000x–0.000x. A reading may sit 5% outside the ratio, and 15% or 1.00 MB outside the sizes. Validated: logical 0.00 MB, disk 0.00 MB, attributed RSS 0.00 MB, ratio 0.000x. Report: logical, disk, attributed RSS, and the ratio held. flatGiven: an empty relate serve, 1 integer properties on every node, text indexes 0, point indexes 0, range indexes 0, and a 32.00 MB logical ceiling. When: the flat shape is loaded to 120000 nodes and 0 relationships, then checkpointed. The child RSS is sampled. Then: the database holds those counts. The load finishes under the ceiling. Logical bytes, disk, attributed RSS, and the ratio stay inside the frozen boundaries. Baseline: logical 26.02 MB – 26.02 MB, disk 1.95 MB – 1.95 MB, attributed RSS 36.49 MB – 36.93 MB, ratio 1.402x–1.419x. A reading may sit 5% outside the ratio, and 15% or 1.00 MB outside the sizes. Validated: logical 26.02 MB, disk 1.26 MB, attributed RSS 37.05 MB, ratio 1.424x. Report: logical, disk, attributed RSS, and the ratio held. fanoutGiven: an empty relate serve, 1 integer properties on every node, text indexes 0, point indexes 0, range indexes 0, and a 32.00 MB logical ceiling. When: the fanout shape is loaded to 52016 nodes and 52000 relationships, then checkpointed. The child RSS is sampled. Then: the database holds those counts. The load finishes under the ceiling. Logical bytes, disk, attributed RSS, and the ratio stay inside the frozen boundaries. Baseline: logical 28.62 MB – 28.62 MB, disk 1.75 MB – 1.75 MB, attributed RSS 34.93 MB – 36.61 MB, ratio 1.220x–1.279x. A reading may sit 5% outside the ratio, and 15% or 1.00 MB outside the sizes. Validated: logical 27.43 MB, disk 1.10 MB, attributed RSS 35.97 MB, ratio 1.311x. Report: logical, disk, attributed RSS, and the ratio held. ringGiven: an empty relate serve, 1 integer properties on every node, text indexes 0, point indexes 0, range indexes 0, and a 32.00 MB logical ceiling. When: the ring shape is loaded to 46000 nodes and 46000 relationships, then checkpointed. The child RSS is sampled. Then: the database holds those counts. The load finishes under the ceiling. Logical bytes, disk, attributed RSS, and the ratio stay inside the frozen boundaries. Baseline: logical 29.99 MB – 29.99 MB, disk 1.77 MB – 1.77 MB, attributed RSS 35.30 MB – 35.89 MB, ratio 1.177x–1.197x. A reading may sit 5% outside the ratio, and 15% or 1.00 MB outside the sizes. Validated: logical 29.99 MB, disk 1.20 MB, attributed RSS 35.64 MB, ratio 1.188x. Report: logical, disk, attributed RSS, and the ratio held. dense ringGiven: an empty relate serve, 1 integer properties on every node, text indexes 0, point indexes 0, range indexes 0, and a 32.00 MB logical ceiling. When: the dense ring shape is loaded to 5000 nodes and 100000 relationships, then checkpointed. The child RSS is sampled. Then: the database holds those counts. The load finishes under the ceiling. Logical bytes, disk, attributed RSS, and the ratio stay inside the frozen boundaries. Baseline: logical 31.41 MB – 31.41 MB, disk 1.62 MB – 1.62 MB, attributed RSS 31.27 MB – 32.46 MB, ratio 0.996x–1.034x. A reading may sit 5% outside the ratio, and 15% or 1.00 MB outside the sizes. Validated: logical 31.11 MB, disk 0.73 MB, attributed RSS 31.73 MB, ratio 1.020x. Report: logical, disk, attributed RSS, and the ratio held. |
|
Memory controls and workspace memory calibration
(comparison document unavailable) |
Summary
Refactor (no behavior change) of relate-front validators, from three review-tasks tickets.
check_projection_subclauses: one driver for a projection's ORDER BY and WITHWHERE(classifies once, resolves the restatable set once) replaces the two entry points.StaticOperand::ValuebecomesLiteral;BoundOperand::ValuebecomesBound, so fold form and bound form read distinctly at each match site.static_types.rs(964 lines) sheds the quantifier-arithmetic walker intostatic_arithmetic.rs;validate_static_operator_typesnarrows topub(crate)(no consumer outside relate-front).Literal/Boundcheck_projection_subclausesdriverRestatable)is_cypher5premise gone; remaining items (executor test dedup,PointValue::is_3d, quantifier doc) are outside relate-front, left openVerification
cargo fmt --all --check,cargo clippy --workspace --all-targets --exclude relate-python -- -D warnings,cargo test -p relate-front -p relate-plannerall clean; full local stellar round: two nits (pre-existingBoundOperandmirror enum, one wrapper fn), no findings above nit.🤖 Generated with Claude Code