You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Pretty print: sort by string if sorting fails #23586
Whenever IPython prints a dict or set, it tries to sort the keys for a nicer output. If the sorting fails, then no sorting is done.
This ticket proposes instead to sort on the string representation if the usual sorting fails. That way, we almost certainly get a deterministic output, which is mainly useful for doctests.
It must be said that sorting rarely fails on Python 2, so this would affect mostly Python 3.
Do you have any idea why the output has changed? I usually find it dangerous to just accept doctest changes like this without understanding the reason.
Activity
fchapoton commentedon Aug 5, 2017
Branch: u/chapoton/23586
fchapoton commentedon Aug 5, 2017
Commit:
9b314ddfchapoton commentedon Aug 5, 2017
New commits:
9b314ddfixing pynormaliz doctestsfchapoton commentedon Aug 7, 2017
bot is morally green
jdemeyer commentedon Aug 11, 2017
Do you have any idea why the output has changed? I usually find it dangerous to just accept doctest changes like this without understanding the reason.
jdemeyer commentedon Aug 11, 2017
Replying to @fchapoton:
Those bots do not have
pynormalizinstalled, that means nothing...On my bots I try to install all optional packages, so
sage4andarandoshould have it.kiwifb commentedon Aug 11, 2017
Looks to me like only the ordering of the solutions has changed. The overall set is still the same.
jdemeyer commentedon Aug 11, 2017
Replying to @kiwifb:
That still doesn't answer the "why" question.
37 remaining items
koffie commentedon Aug 31, 2017
Why needs review? I agree with the new description. But we still need to see if IPython accepts our PR and update ipython after it had done so.
koffie commentedon Aug 31, 2017
Upstream: Reported upstream. No feedback yet.
videlec commentedon Nov 24, 2017
Pull request has been merged...
fchapoton commentedon Oct 10, 2021
close as obsolete ?
kiwifb commentedon Oct 10, 2021
Reviewer: François Bissey
kiwifb commentedon Oct 10, 2021
Seems like the people involved lost interest 4 years ago so let's obsolete it.