Skip to content

Some preparations for binding=True #25848

Closed

Description

@jdemeyer

These are a few assorted fixes to enable binding=True:

  1. Enable binding=True on some non-performance-critical unpickling functions. These regularly occur in __reduce__ doctests, causing annoying doctest failures. In a few cases, the unpickling function can be removed completely.

  2. Compile __getmetaclass__ with binding=False otherwise it won't work.

  3. Resolve a cyclic import involving sage.rings.convert.mpfi by explicitly importing it.

  4. In src/sage/categories/category.py, assign the helpers as staticmethod to prevent binding.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: e240df3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/25848

Activity

  1. added this to the sage-8.4 milestone on Jul 12, 2018
  2. jdemeyer commented on Jul 12, 2018

    @jdemeyer
    Author
  3. jdemeyer commented on Jul 12, 2018

    @jdemeyer
    ContributorAuthor
  4. sagetrac-git commented on Jul 13, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    6e6e1ebSome preparations for binding=True
  5. sagetrac-git commented on Jul 13, 2018

    sagetrac-gitmannequin
    Mannequin

    Commit: 6e6e1eb

  6. tscrim commented on Jul 13, 2018

    @tscrim
    Collaborator

    Reviewer: Travis Scrimshaw

  7. tscrim commented on Jul 13, 2018

    @tscrim
    Collaborator
    comment:5

    Green bot => positive review.

  8. tscrim commented on Jul 17, 2018

    @tscrim
    Collaborator
    comment:6

    Looks like one real failure from the patchbot:

    sage -t --long src/sage/modular/modsym/p1list.pyx  # 2 doctests failed
    
  9. sagetrac-git commented on Jul 19, 2018

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 6e6e1eb to e240df3

  10. sagetrac-git commented on Jul 19, 2018

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    e240df3Some preparations for binding=True
  11. vbraun commented on Aug 5, 2018

    @vbraun
    Member
  12. added a commit that references this issue on Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions