You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are a few assorted fixes to enable binding=True:
Enable binding=True on some non-performance-critical unpickling functions. These regularly occur in __reduce__ doctests, causing annoying doctest failures. In a few cases, the unpickling function can be removed completely.
Compile __getmetaclass__ with binding=False otherwise it won't work.
Resolve a cyclic import involving sage.rings.convert.mpfi by explicitly importing it.
In src/sage/categories/category.py, assign the helpers as staticmethod to prevent binding.
Activity
jdemeyer commentedon Jul 12, 2018
jdemeyer commentedon Jul 12, 2018
Branch: u/jdemeyer/some_preparations_for_binding_true
sagetrac-git commentedon Jul 13, 2018
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
6e6e1ebSome preparations for binding=Truesagetrac-git commentedon Jul 13, 2018
Commit:
6e6e1ebtscrim commentedon Jul 13, 2018
Reviewer: Travis Scrimshaw
tscrim commentedon Jul 13, 2018
Green bot => positive review.
tscrim commentedon Jul 17, 2018
Looks like one real failure from the patchbot:
sagetrac-git commentedon Jul 19, 2018
Changed commit from
6e6e1ebtoe240df3sagetrac-git commentedon Jul 19, 2018
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
e240df3Some preparations for binding=Truevbraun commentedon Aug 5, 2018
Changed branch from u/jdemeyer/some_preparations_for_binding_true to
e240df3