You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix doctest in gap_packages when ~/.gap is not empty #28233
One of the doctest in the file sage/tests/gap_packages.py has a result that can depend on the content of the testing user's home directory. Namely if ~/.gap exist and it is not empty
sage -t --long /usr/lib64/python2.7/site-packages/sage/tests/gap_packages.py
**********************************************************************
File "/usr/lib64/python2.7/site-packages/sage/tests/gap_packages.py", line 137, in sage.tests.gap_packages.all_installed_packages
Failed example:
all_installed_packages() == all_installed_packages(gap=gap)
Expected:
True
Got:
False
This can be fixed by telling the test to ignore the content of ~/.gap.
Reminder: this happens because by default libgap always look at the content of ~/.gap but the pexpect interface to gap doesn't. This ticket explicitly discards the content of ~/.gap in all cases.
I think given the status of gap -r that this is the best thing to do. It, of course, does work. Should the description doctest be relative to vanilla Sage? If so, I can change this if you do not have access to vanilla.
Activity
kiwifb commentedon Jul 23, 2019
Author: François Bissey
kiwifb commentedon Jul 23, 2019
Reminder: this happens because by default
libgapalways look at the content of~/.gapbut the pexpect interface togapdoesn't. This ticket explicitly discards the content of~/.gapin all cases.New commits:
25d55f9Use "ignore_dot_gap" in the all_installed_packages doctest for consistency.kiwifb commentedon Jul 23, 2019
Branch: u/fbissey/gap_packages_doctest
kiwifb commentedon Jul 23, 2019
Commit:
25d55f9strogdon commentedon Jul 23, 2019
Reviewer: Steven Trogdon
strogdon commentedon Jul 23, 2019
I think given the status of
gap -rthat this is the best thing to do. It, of course, does work. Should the description doctest be relative to vanilla Sage? If so, I can change this if you do not have access to vanilla.kiwifb commentedon Jul 23, 2019
No it doesn't matter. Leave it be.
vbraun commentedon Jul 29, 2019
Changed branch from u/fbissey/gap_packages_doctest to
25d55f9