Skip to content

from gap to libgap in strongly_regular_db #28818

Closed

Description

@dimpase

remove the last use of GAP pexpect in that file;

remove no longer needed #optional tags in some tests

CC: @fchapoton @dcoudert

Component: graph theory

Author: Dima Pasechnik

Branch/Commit: 6489a18

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/28818

Activity

  1. added this to the sage-8.9 milestone on Nov 28, 2019
  2. dimpase commented on Nov 28, 2019

    @dimpase
    MemberAuthor
    comment:1

    this should make this a bit more robust and quick

  3. dimpase commented on Nov 28, 2019

    @dimpase
    MemberAuthor

    Reviewer: dcoudert

  4. modified the milestones: sage-8.9, sage-9.0 on Nov 28, 2019
  5. sagetrac-git commented on Nov 29, 2019

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 249d582 to 23d6a45

  6. sagetrac-git commented on Nov 29, 2019

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    23d6a45use libgap instead of gap, remove no longer needed #optional
  7. dimpase commented on Nov 29, 2019

    @dimpase
    MemberAuthor
    comment:4

    a bit of cleanup in the updated commit

  8. sagetrac-git commented on Nov 29, 2019

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 23d6a45 to 82ec1c3

  9. sagetrac-git commented on Nov 29, 2019

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    82ec1c3use libgap instead of gap, remove no longer needed #optional
  10. sagetrac-git commented on Nov 29, 2019

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 82ec1c3 to b3183e8

  11. 15 remaining items

  12. vbraun commented on Dec 3, 2019

    @vbraun
    Member
    comment:16

    I'm getting timeouts at

    sage: gg = graphs.HallJankoGraph(from_string=False) # long time ## line 683 ##
    

    and

    sage: g=SRG_280_135_70_60()                  # long time ## line 2243 ##
    

    resulting in

    sage -t --long src/sage/graphs/generators/smallgraphs.py  # Timed out
    sage -t --long src/sage/graphs/strongly_regular_db.pyx  # Timed out
    

    Several buildbots time out at the same test so its reproducable...

  13. dimpase commented on Dec 3, 2019

    @dimpase
    MemberAuthor
    comment:17

    these tests need internet connection to cache data via GAP's AtlasRep package.
    One can tag them # optional - internet

  14. vbraun commented on Dec 4, 2019

    @vbraun
    Member
    comment:18

    please do!

  15. sagetrac-git commented on Dec 4, 2019

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

    5fed72fuse libgap instead of gap, remove no longer needed #optional
    2b08c1ause libgap to compute orbit lengths on edges/arcs
    70f67e5fix for outdated code, tests for LivinstoneGraph
    6489a18 # optional - internet tags for AtlasRep uses
  16. sagetrac-git commented on Dec 4, 2019

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 1bf4fac to 6489a18

  17. dimpase commented on Dec 4, 2019

    @dimpase
    MemberAuthor
    comment:20

    rebased over latest beta, added commit ​6489a18 (with # optional - internet tags)

    off to bots again.

  18. dcoudert commented on Dec 4, 2019

    @dcoudert
    Collaborator
    comment:21

    I have the same errors when I try ./sage -tp --long --optional=sage,optional,external src/sage/graphs/ but not when I try ./sage -tp --long src/sage/graphs/. So added flags are working well.

    LGTM.

  19. vbraun commented on Dec 8, 2019

    @vbraun
    Member

    Changed branch from u/dimpase/graphs/srgupd to 6489a18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions