Skip to content

Update sympy to 1.5 #28911

Closed
Closed

Description

@antonio-rojas

Removed merged match, updated a few doctest results

Tarball: https://github.com/sympy/sympy/releases/download/sympy-1.5/sympy-1.5.tar.gz

CC: @kiwifb @timokau @saraedum @slel

Component: packages: standard

Author: Antonio Rojas

Branch/Commit: c6d0308

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/28911

Activity

  1. added this to the sage-9.0 milestone on Dec 25, 2019
  2. antonio-rojas commented on Dec 25, 2019

    @antonio-rojas
    MemberAuthor
  3. antonio-rojas commented on Dec 25, 2019

    @antonio-rojas
    MemberAuthor

    Commit: c6d0308

  4. antonio-rojas commented on Dec 25, 2019

    @antonio-rojas
    Author
  5. antonio-rojas commented on Dec 25, 2019

    @antonio-rojas
    MemberAuthor

    Author: Antonio Rojas

  6. antonio-rojas commented on Dec 25, 2019

    @antonio-rojas
    MemberAuthor

    New commits:

    c6d0308Update sympy to 1.5
  7. kiwifb commented on Dec 26, 2019

    @kiwifb
    Member
    comment:3

    Finally got rid of that patch? That's awesome news.

    I am not familiar with lambert_w but that test in sage/symbolic/relation.py should be checked by someone who knows if it is correct. The other tests are just a matter of factorization.

  8. antonio-rojas commented on Dec 26, 2019

    @antonio-rojas
    MemberAuthor
    comment:4

    Both are correct,

    lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))
    

    so

    (2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))
    
  9. kiwifb commented on Dec 26, 2019

    @kiwifb
    Member
    comment:5

    Replying to @antonio-rojas:

    Both are correct,

    lambert_w(±1/2) = ±(1/2)exp(-lambert_w(±1/2))
    

    so

    (2·lambert_w(±1/2))^2 = 1/exp(2·lambert_w(±1/2))
    

    Now, I understand, it is just another root of the equation and the order in which they are stored has changed. It all looks good to me.

  10. kiwifb commented on Dec 26, 2019

    @kiwifb
    Member

    Reviewer: François Bissey

  11. timokau commented on Dec 26, 2019

    @timokau
    Contributor
    comment:6

    Thank you for taking care of this!

  12. fchapoton commented on Jan 1, 2020

    @fchapoton
    Contributor
    comment:7

    9.0 is out

  13. modified the milestones: sage-9.0, sage-9.1 on Jan 1, 2020
  14. vbraun commented on Jan 5, 2020

    @vbraun
    Member

    Changed branch from u/arojas/update_sympy_to_1_5 to c6d0308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions