Skip to content

Upgrade FLINT to 2.8.4, arb to 2.22.1 #32211

Closed

Description

@mkoeppe

FLINT 2.8.1 and FLINT 2.8.2 announced, then FLINT 2.8.3,
then FLINT 2.8.4:

Arb release history:

Depends on #33189

CC: @slel

Component: packages: standard

Keywords: upgrade, arb, flint

Author: Jonathan Kliem, Matthias Koeppe

Branch/Commit: 45f4984

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32211

Activity

  1. mkoeppe commented on Jul 16, 2021

    @mkoeppe
    ContributorAuthor
  2. mkoeppe commented on Jul 16, 2021

    @mkoeppe
    ContributorAuthor

    New commits:

    6d14c45build/pkgs/flint: Use 2.8.0-rc2
  3. mkoeppe commented on Jul 16, 2021

    @mkoeppe
    ContributorAuthor
  4. mkoeppe commented on Jul 16, 2021

    @mkoeppe
    ContributorAuthor

    Commit: 6d14c45

  5. sagetrac-git commented on Jul 16, 2021

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    ac46936build/pkgs/flint/spkg-install.in: Use cmake
  6. sagetrac-git commented on Jul 16, 2021

    sagetrac-gitmannequin
    Mannequin

    Changed commit from 6d14c45 to ac46936

  7. sagetrac-git commented on Jul 17, 2021

    sagetrac-gitmannequin
    Mannequin

    Changed commit from ac46936 to 9ea2e5c

  8. sagetrac-git commented on Jul 17, 2021

    sagetrac-gitmannequin
    Mannequin

    Branch pushed to git repo; I updated commit sha1. New commits:

    9ea2e5cbuild/pkgs/arb/patches: Add https://github.com/fredrik-johansson/arb/commit/b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170
  9. mkoeppe commented on Jul 17, 2021

    @mkoeppe
    ContributorAuthor
  10. mkoeppe commented on Jul 17, 2021

    @mkoeppe
    ContributorAuthor
    comment:6

    After switching to the cmake build system:

    Failure on ubuntu-trusty-standard (where Sage rejects system ntl), likely because FLINT accepts system NTL:

    -- Detecting CXX compile features - done
    -- Found GMP: /usr/include/x86_64-linux-gnu (Required is at least version "6.0.0") 
    -- Found MPFR: /usr/include (Required is at least version "1.0.0") 
    -- Found NTL: /usr/lib/libntl.so  
    -- Found PythonInterp: /usr/bin/python (found version "2.7.6") 
    -- Found CBLAS: /usr/include  
    ...
    lib/libflint.so.16.1.0: undefined reference to `_ntl_gscompare(_ntl_gbigint_body*, long)'
    lib/libflint.so.16.1.0: undefined reference to `_ntl_gmod(_ntl_gbigint_body*, _ntl_gbigint_body*, _ntl_gbigint_body**)'
    lib/libflint.so.16.1.0: undefined reference to `_ntl_gfree(_ntl_gbigint_body*)'
    lib/libflint.so.16.1.0: undefined reference to `_ntl_gsetlength(_ntl_gbigint_body**, long)'
    lib/libflint.so.16.1.0: undefined reference to `mpfr_rootn_ui'
    lib/libflint.so.16.1.0: undefined reference to `NTL::TerminalError(char const*)'
    collect2: error: ld returned 1 exit status
    make[5]: *** [bin/test-t-umul_ppmm] Error 1
    

    (ubuntu-trusty-minimal, i.e., without installation of system ntl, is OK)

    Likewise ubuntu-xenial, debian-jessie, debian-stretch, etc.

  11. mkoeppe commented on Aug 2, 2021

    @mkoeppe
    Author
  12. mkoeppe commented on Sep 25, 2021

    @mkoeppe
    Author
  13. antonio-rojas commented on Sep 26, 2021

    @antonio-rojas
    Member

    Changed dependencies from #32175 to #32175 #32567

  14. mkoeppe commented on Oct 1, 2021

    @mkoeppe
    Author
  15. mkoeppe commented on Oct 2, 2021

    @mkoeppe
    ContributorAuthor
  16. 42 remaining items

  17. dimpase commented on Feb 4, 2022

    @dimpase
    Member
    comment:45

    lgtm

  18. dimpase commented on Feb 4, 2022

    @dimpase
    Member

    Reviewer: Dima Pasechnik

  19. mkoeppe commented on Feb 4, 2022

    @mkoeppe
    ContributorAuthor
    comment:46

    Thanks.

  20. vbraun commented on Feb 7, 2022

    @vbraun
    Member
  21. dimpase commented on Feb 7, 2022

    @dimpase
    Member
    comment:48

    Volker, you did not merge the dependency, #33189, that's why you got errors, e.g. here:
    https://github.com/vbraun/sage/blob/7b26bb58475d9bc707bc9ed7d2a63351f2f4686c/src/sage/rings/real_arb.pyx#L3509

    It should be

    sage: RBF(1/2).erf() # abs tol 1e-16
    

    and not

    sage: RBF(1/2).erf()
    

    as in the branch you're testing.

  22. dimpase commented on Feb 7, 2022

    @dimpase
    Member
    comment:49

    When I added #33189 and set this to positive review, #33189 was already marked as merged,so I don't really understand how it was tested without it in the end.

  23. vbraun commented on Feb 12, 2022

    @vbraun
    Member

    Changed branch from u/mkoeppe/flint_2_8_4 to 45f4984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions