Skip to content

sage.geometry.polyhedron.backend_cdd: Go through sage.features for _cdd_executable #32645

Closed

Description

@mkoeppe

This is so that the Sage library becomes fully functional even when not being run from within sage-env (which sets PATH).

To test (when cddlib is not present in the system but installed as SPKG):

venv/bin/python3 -c 'from sage.all import *; print(Polyhedron(vertices=[[1.123456789012345, 2.123456789012345]], base_ring=RDF))'

Depends on #31296

CC: @kliem @saraedum

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 14d3a65

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32645

Activity

  1. mkoeppe commented on Mar 5, 2022

    @mkoeppe
    ContributorAuthor

    Dependencies: #31296

  2. mkoeppe commented on Mar 6, 2022

    @mkoeppe
    ContributorAuthor

    Last 10 new commits:

    a93e9afsrc/sage/features/__init__.py: Simplify Executable.absolute_path
    5b25c1dsage.features: Refactor StaticFile, Executable through a new base class FileFeature
    6c35717sage.features.FileFeature: Replace method absolute_path by absolute_filename, with deprecation
    9266709Merge #31292
    a4d0ed6sage.interfaces.four_ti_2: Use Executable.absolute_filename
    4252ea3sage.sandpiles.sandpile: Use Executable.absolute_filename() when interfacing 4ti2
    17b9fdesage.interfaces.latte: Use Executable.absolute_filename
    777e643Merge #31296
    bbb6c1fsage.features.cddlib: New
    14d3a65sage.geometry.polyhedron.backend_cdd: Use CddExecutable(...).absolute_filename()
  3. mkoeppe commented on Mar 6, 2022

    @mkoeppe
    ContributorAuthor

    Commit: 14d3a65

  4. mkoeppe commented on Mar 6, 2022

    @mkoeppe
    ContributorAuthor

    Author: Matthias Koeppe

  5. mkoeppe commented on Mar 6, 2022

    @mkoeppe
    Author
  6. tscrim commented on Mar 7, 2022

    @tscrim
    Collaborator
    comment:5

    LGTM.

  7. tscrim commented on Mar 7, 2022

    @tscrim
    Collaborator

    Reviewer: Travis Scrimshaw

  8. mkoeppe commented on Mar 7, 2022

    @mkoeppe
    ContributorAuthor
    comment:6

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions