Skip to content

Meta-ticket: Split sage.geometry.polyhedron.base #32651

Closed

Description

@mkoeppe

This is a pretty large module, consisting of 11 kLOC.

We could split it into several modules, each defining an intermediate class (like it is done in sage.matrix.matrix0, matrix1, matrix2).

For example,

This could also lead to an improvement of the documentation.

CC: @kliem @jplab @tscrim

Component: refactoring

Issue created by migration from https://trac.sagemath.org/ticket/32651

Activity

  1. mkoeppe commented on Oct 8, 2021

    @mkoeppe
    Author
  2. kliem commented on Oct 25, 2021

    @kliem
  3. kliem commented on Oct 26, 2021

    @kliem
  4. mkoeppe commented on Nov 9, 2021

    @mkoeppe
    Author
  5. kliem commented on Nov 15, 2021

    @kliem
  6. kliem commented on Nov 16, 2021

    @kliem
  7. slel commented on Nov 16, 2021

    @slel
  8. kliem commented on Nov 17, 2021

    @kliem
  9. kliem commented on Jan 5, 2022

    @kliem
  10. kliem commented on Mar 2, 2022

    @kliem
  11. kliem commented on Mar 28, 2022

    @kliem
  12. kliem commented on Mar 31, 2022

    @kliem
    Contributor
    comment:13

    Is this done with #33583? What did you have in mind with "This could also lead to an improvement of the documentation."?

  13. jplab commented on Apr 7, 2022

    @jplab
    Contributor
    comment:14

    That's a great ticket! ... I'm not dead. I expect to be "back on trac" soon!

    I would be up for improving the doc and complement it further... I'll slowly go through all this new stuff in polyhedron this Summer.

    Thanks for all the work!

  14. jhpalmieri commented on Jul 16, 2022

    @jhpalmieri
    Member
    comment:17

    Is this done?

  15. mkoeppe commented on Jul 16, 2022

    @mkoeppe
    ContributorAuthor
    comment:18

    It's done except we didn't get around to do "an improvement of the documentation" (comment:13) -- in the course of which we would surely have noticed that the documentation for all of this is no longer being built (#25675).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions