Repository navigation
Closed
Description
This is a pretty large module, consisting of 11 kLOC.
We could split it into several modules, each defining an intermediate class (like it is done in sage.matrix.matrix0, matrix1, matrix2).
For example,
- a module
sage.geometry.polyhedron.base0contains the very basic methods (initialization etc) Split initialization and basic access of polyhedra out as a separate module #32767. - a module
sage.geometry.polyhedron.base1could contain the implementation of the methods defined by theConvexSet_baseAPI, split convex set methods of polyhedra into base1.py #32776 - a module
sage.geometry.polyhedron.base2could contain all methods that have to do with lattice points in polyhedra, Move lattice point methods from Polyhedron_base to Polyhedron_base2 #32876 - a module
sage.geometry.polyhedron.base3contains the combinatorial methods, Move combinatorial methods of Polyhedron_base to Polyhedron_base3 #32884 - a module
sage.geometry.polyhedron.base4could contain all methods whose implementation needssage.graphs.graphs, Move graphs methods to Polyhedron_base4 #32889 -- this would help with modularization because then we could conditionalize the doctests via a file-level directive (sage.doctest.control: Exclude doctests in files via file directives ''# sage.doctest: optional - xyz' #30778)vertex_graph,graph,vertex_digraph,vertex_facet_graphhasse_diagramface_lattice,flag_f_vector{combinatorial,restricted}_automorphism_groupis_combinatorially_isomorphic
- a module
sage.geometry.polyhedron.base5could contain all constructions of new polyhedra, Move construction methods to Polyhedron_base5 #33123 - a module
sage.geometry.polyhedron.base6could contain all methods related to plotting and affine hull (projection), Move plotting and affine hull to Polyhedron_base6 #33449 - a module
sage.geometry.polyhedron.base7could contain all methods related to triangulation and volume, Move integration and volume to Polyhedron_base7 #33583
This could also lead to an improvement of the documentation.
Component: refactoring
Issue created by migration from https://trac.sagemath.org/ticket/32651
Activity
mkoeppe commentedon Oct 8, 2021
kliem commentedon Oct 25, 2021
kliem commentedon Oct 26, 2021
mkoeppe commentedon Nov 9, 2021
kliem commentedon Nov 15, 2021
kliem commentedon Nov 16, 2021
slel commentedon Nov 16, 2021
kliem commentedon Nov 17, 2021
kliem commentedon Jan 5, 2022
kliem commentedon Mar 2, 2022
kliem commentedon Mar 28, 2022
kliem commentedon Mar 31, 2022
Is this done with #33583? What did you have in mind with "This could also lead to an improvement of the documentation."?
jplab commentedon Apr 7, 2022
That's a great ticket! ... I'm not dead. I expect to be "back on trac" soon!
I would be up for improving the doc and complement it further... I'll slowly go through all this new stuff in polyhedron this Summer.
Thanks for all the work!
jhpalmieri commentedon Jul 16, 2022
Is this done?
mkoeppe commentedon Jul 16, 2022
It's done except we didn't get around to do "an improvement of the documentation" (comment:13) -- in the course of which we would surely have noticed that the documentation for all of this is no longer being built (#25675).