You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sage -t --random-seed=141799432516026950115879763089480345171 src/sage/calculus/calculus.py
**********************************************************************
File "src/sage/calculus/calculus.py", line 1642, in sage.calculus.calculus.laplace
Failed example:
a, cond
Expected:
(-oo, True)
Got:
(0, True)
**********************************************************************
This appears to be a deliberate change in sympy. We update the doctest.
Some doctests need updating because of changes to expression canonicalization in sympy:
sage -t --random-seed=141799432516026950115879763089480345171 src/sage/manifolds/continuous_map.py
**********************************************************************
File "src/sage/manifolds/continuous_map.py", line 1359, in sage.manifolds.continuous_map.ContinuousMap.coord_functions
Failed example:
Phi.coord_functions(c_UV, c_xyz)
Expected:
Coordinate functions (-U**2/4 + V**2/4, -(U + V)/(U - V), V)
on the Chart (M, (U, V))
Got:
Coordinate functions (-U**2/4 + V**2/4, (-U - V)/(U - V), V) on the Chart (M, (U, V))
We update these doctests. They will fail now with older versions of sympy. However, we do not adjust the version bounds in build/pkgs/sympy/install-requires.txt.
Thanks for the report. What should be the action here? Shall we wait for the release of SymPy 1.10 and its integration as a Sage standard package? Otherwise, there will be doctest failures with SymPy 1.9 --- the current version in Sage.
Activity
mkoeppe commentedon Feb 21, 2022
For this failure in
src/sage/symbolic/expression_conversions.py, I have opened sympy/sympy#23144mkoeppe commentedon Feb 21, 2022
A few more that are only seen with
sage -t --long:egourgoulhon commentedon Feb 22, 2022
Thanks for the report. What should be the action here? Shall we wait for the release of SymPy 1.10 and its integration as a Sage standard package? Otherwise, there will be doctest failures with SymPy 1.9 --- the current version in Sage.
mkoeppe commentedon Feb 25, 2022
Replying to @mkoeppe:
Fixed now in master and the 1.10 branch by sympy/sympy#23162, sympy/sympy#23166
mkoeppe commentedon Feb 25, 2022
Replying to @egourgoulhon:
Yes, I think so
mkoeppe commentedon Feb 25, 2022
Replying to @mkoeppe:
This change to
laplace_transformseems to be a deliberate change in sympy, not a regression.mkoeppe commentedon Mar 4, 2022
Branch: u/mkoeppe/update_doctests_for_compatibility_with_sympy_1_10
mkoeppe commentedon Mar 4, 2022
New commits:
cd66605build/pkgs/sympy: Update to 1.10rc3c49eff3src/sage/calculus/calculus.py: Update laplace doctest for sympy 1.10mkoeppe commentedon Mar 4, 2022
Author: Matthias Koeppe
mkoeppe commentedon Mar 4, 2022
Commit:
c49eff3sagetrac-git commentedon Mar 5, 2022
Changed commit from
c49eff3to609dd9dsagetrac-git commentedon Mar 5, 2022
Branch pushed to git repo; I updated commit sha1. New commits:
609dd9dsage.manifolds: Update doctests for SymPy 1.10mkoeppe commentedon Mar 5, 2022
sagetrac-git commentedon Mar 6, 2022
Changed commit from
609dd9dto6b7c3a2sagetrac-git commentedon Mar 6, 2022
Branch pushed to git repo; I updated commit sha1. New commits:
6b7c3a2build/pkgs/sympy: Update to 1.10mkoeppe commentedon Mar 6, 2022
mkoeppe commentedon Mar 6, 2022
egourgoulhon commentedon Mar 6, 2022
LGTM. Thanks!
egourgoulhon commentedon Mar 6, 2022
Reviewer: Eric Gourgoulhon
vbraun commentedon Mar 9, 2022
Changed branch from u/mkoeppe/update_doctests_for_compatibility_with_sympy_1_10 to
6b7c3a2