Skip to content

Update ipykernel to 6.13.0 - reintroduces psutil #33772

Closed

Description

@mkoeppe

ipykernel >= 6.7.0 now requires psutil - https://ipykernel.readthedocs.io/en/stable/changelog.html#id33 - removed in #32656

Previous update of ipykernel was done in #33020.

CC: @orlitzky @williamstein @tornaria

Component: packages: standard

Branch/Commit: u/mkoeppe/update_ipykernel_to_6_13_0___reintroduces_psutil @ 6bc0e43

Issue created by migration from https://trac.sagemath.org/ticket/33772

Activity

  1. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor
  2. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor

    Commit: 6bc0e43

  3. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor

    New commits:

    6bc0e43build/pkgs/ipykernel: Update to 6.13.0
  4. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    Author
  5. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    Author
  6. kiwifb commented on Apr 29, 2022

    @kiwifb
    Member
    comment:4

    Well it depends on a python package named psutils because it mimics that functionality, but the python package in question do not require the C package psutil.

    https://github.com/giampaolo/psutil https://pypi.org/project/psutil/

    So the plot twist is that we can really dump the old "psutil" package in favor of something designed to be more cross platform from the start.

  7. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor
    comment:5

    Hm? No, it's the same Python package that was dumped in #32656 but is now needed again for ipykernel.

  8. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor
    comment:6

    Upstream psutil still doesn't support Cygwin (as far as I can see)

  9. kiwifb commented on Apr 29, 2022

    @kiwifb
    Member
    comment:7

    My mistake, I always thought it was another package that was being discussed. In fact I may have had a wrong dependency for a while :(

  10. orlitzky commented on Apr 29, 2022

    @orlitzky
    Contributor
    comment:8

    Well, I know when I'm beaten. It looks like ipykernel is making the same mistakes that sage did; (a) reckless introduction of dependencies to obtain (b) meaningless memory metrics.

    I don't have the energy to fight it, I'm going outside.

  11. mkoeppe commented on Apr 29, 2022

    @mkoeppe
    ContributorAuthor
    comment:9

    After some fresh air, we can try to get a simple patch into psutil that minimally supports Cygwin by just returning a meaningless positive constant.

    (The last attempt to get Cygwin support into psutil was trying to get a highly intrusive megapatch in.)

  12. dimpase commented on Apr 30, 2022

    @dimpase
    Member
    comment:10

    I doubt psutil will take any Cygwin patches (Erik's attempts to get the patch considered deteriorated into a huge fight).

    We'd need a drop-in replacement on Cygwin :-(

  13. dimpase commented on Apr 30, 2022

    @dimpase
    Member
    comment:11

    IMHO less and less projects are willing to mess with Cygwin, (rightly) considering it to be a dying, obsolete, semi-broken, and dodgy.

  14. mkoeppe commented on Jun 26, 2022

    @mkoeppe
    ContributorAuthor
    comment:12

    I don't think that's a trend. In the past, no project even had a Cygwin test infrastructure. This has changed with the availability of GitHub Actions - in particular https://github.com/cygwin/cygwin-install-action
    Also, in the past, MinGW and Cygwin carried their own downstream patches for CPython etc. This is now getting increasingly upstreamed (search in https://setuptools.pypa.io/en/latest/history.html)

  15. dimpase commented on Jun 27, 2022

    @dimpase
    Member
    comment:13

    Replying to @mkoeppe:

    I don't think that's a trend. In the past, no project even had a Cygwin test infrastructure. This has changed with the availability of GitHub Actions - in particular https://github.com/cygwin/cygwin-install-action
    Also, in the past, MinGW and Cygwin carried their own downstream patches for CPython etc. This is now getting increasingly upstreamed (search in https://setuptools.pypa.io/en/latest/history.html)

    but the upstream (Jupyter & Co) don't even try to support Cygwin.

  16. dimpase commented on Jun 30, 2022

    @dimpase
    Member
    comment:14

    I think it's OK to make ipython and jupyter optional. After all, although I'm not 100% sure, it ought to be possible to use a native Windows Jupyter to connect to the cygwin Sage jupyter kernel.

  17. mkoeppe commented on Jun 30, 2022

    @mkoeppe
    ContributorAuthor
    comment:15

    #30306 lists a number of tickets to try out and document such setups, but nobody has done the work

  18. added 2 commits that reference this issue on Dec 4, 2023
    e922bd0
    f336f6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions