You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update ipykernel to 6.13.0 - reintroduces psutil #33772
Well it depends on a python package named psutils because it mimics that functionality, but the python package in question do not require the C package psutil.
Well, I know when I'm beaten. It looks like ipykernel is making the same mistakes that sage did; (a) reckless introduction of dependencies to obtain (b) meaningless memory metrics.
I don't have the energy to fight it, I'm going outside.
I don't think that's a trend. In the past, no project even had a Cygwin test infrastructure. This has changed with the availability of GitHub Actions - in particular https://github.com/cygwin/cygwin-install-action
Also, in the past, MinGW and Cygwin carried their own downstream patches for CPython etc. This is now getting increasingly upstreamed (search in https://setuptools.pypa.io/en/latest/history.html)
I don't think that's a trend. In the past, no project even had a Cygwin test infrastructure. This has changed with the availability of GitHub Actions - in particular https://github.com/cygwin/cygwin-install-action
Also, in the past, MinGW and Cygwin carried their own downstream patches for CPython etc. This is now getting increasingly upstreamed (search in https://setuptools.pypa.io/en/latest/history.html)
but the upstream (Jupyter & Co) don't even try to support Cygwin.
I think it's OK to make ipython and jupyter optional. After all, although I'm not 100% sure, it ought to be possible to use a native Windows Jupyter to connect to the cygwin Sage jupyter kernel.
Activity
mkoeppe commentedon Apr 29, 2022
Branch: u/mkoeppe/update_ipykernel_to_6_13_0___reintroduces_psutil
mkoeppe commentedon Apr 29, 2022
Commit:
6bc0e43mkoeppe commentedon Apr 29, 2022
New commits:
6bc0e43build/pkgs/ipykernel: Update to 6.13.0mkoeppe commentedon Apr 29, 2022
mkoeppe commentedon Apr 29, 2022
kiwifb commentedon Apr 29, 2022
Well it depends on a python package named psutils because it mimics that functionality, but the python package in question do not require the C package psutil.
https://github.com/giampaolo/psutil https://pypi.org/project/psutil/
So the plot twist is that we can really dump the old "psutil" package in favor of something designed to be more cross platform from the start.
mkoeppe commentedon Apr 29, 2022
Hm? No, it's the same Python package that was dumped in #32656 but is now needed again for ipykernel.
mkoeppe commentedon Apr 29, 2022
Upstream psutil still doesn't support Cygwin (as far as I can see)
kiwifb commentedon Apr 29, 2022
My mistake, I always thought it was another package that was being discussed. In fact I may have had a wrong dependency for a while :(
orlitzky commentedon Apr 29, 2022
Well, I know when I'm beaten. It looks like ipykernel is making the same mistakes that sage did; (a) reckless introduction of dependencies to obtain (b) meaningless memory metrics.
I don't have the energy to fight it, I'm going outside.
mkoeppe commentedon Apr 29, 2022
After some fresh air, we can try to get a simple patch into
psutilthat minimally supports Cygwin by just returning a meaningless positive constant.(The last attempt to get Cygwin support into
psutilwas trying to get a highly intrusive megapatch in.)dimpase commentedon Apr 30, 2022
I doubt
psutilwill take any Cygwin patches (Erik's attempts to get the patch considered deteriorated into a huge fight).We'd need a drop-in replacement on Cygwin :-(
dimpase commentedon Apr 30, 2022
IMHO less and less projects are willing to mess with Cygwin, (rightly) considering it to be a dying, obsolete, semi-broken, and dodgy.
mkoeppe commentedon Jun 26, 2022
I don't think that's a trend. In the past, no project even had a Cygwin test infrastructure. This has changed with the availability of GitHub Actions - in particular https://github.com/cygwin/cygwin-install-action
Also, in the past, MinGW and Cygwin carried their own downstream patches for CPython etc. This is now getting increasingly upstreamed (search in https://setuptools.pypa.io/en/latest/history.html)
dimpase commentedon Jun 27, 2022
Replying to @mkoeppe:
but the upstream (Jupyter & Co) don't even try to support Cygwin.
dimpase commentedon Jun 30, 2022
I think it's OK to make ipython and jupyter optional. After all, although I'm not 100% sure, it ought to be possible to use a native Windows Jupyter to connect to the cygwin Sage jupyter kernel.
mkoeppe commentedon Jun 30, 2022
#30306 lists a number of tickets to try out and document such setups, but nobody has done the work
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD
src/sage/doctest/util.py: cputime for pexpect interfaces on Linux/BSD