You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's a bug in the tests there; obviously it should be using gap3 (as it otherwise does not test the implementation in this function!), not gap (i.e. gap4). So we should apply
Otherwise we merely testing what gap4 can do (and what you see is that gap4.13 is broken at this place).
Unfortunately the diff above, with gap3 installed, gives
File "src/sage/interfaces/gap3.py", line 757, in sage.interfaces.gap3.GAP3Element._latex_
Failed example:
s._latex_()
Expected:
'\\left(\\begin{array}{rr} 1&2\\\\ 3/4&\\frac{5}{6}\\\\ \\end{array}\\right)'
Got:
'1&2\\\\\\n\\frac34&\\frac56\\\\\\n'
**********************************************************************
File "src/sage/interfaces/gap3.py", line 759, in sage.interfaces.gap3.GAP3Element._latex_
Failed example:
latex(s)
Expected:
\left(\begin{array}{rr} 1&2\\ 3/4&\frac{5}{6}\\ \end{array}\right)
Got:
1&2\\\n\frac34&\frac56\\\n
OTOH gap3 is an experimental package, so this is tolerable (without gap3 installed, there won't be a doctest failure here, after this patch is applied.
There's one more failure that only manifests itself if bliss is installed
sage -t --long --random-seed=192739335773734784141473037713226530622 /usr/lib/python3.12/site-packages/sage/graphs/generic_graph.py
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/graphs/generic_graph.py", line 23617, in sage.graphs.generic_graph.GenericGraph.?
Failed example:
G.is_isomorphic(H)
Exception raised:
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 714, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/usr/lib/python3.12/site-packages/sage/doctest/forker.py", line 1146, in compile_and_execute
exec(compiled, globs)
File "<doctest sage.graphs.generic_graph.GenericGraph.?[14]>", line 1, in <module>
G.is_isomorphic(H)
File "/usr/lib/python3.12/site-packages/sage/groups/perm_gps/permgroup.py", line 4287, in is_isomorphic
iso = self._libgap_().IsomorphismGroups(right)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "sage/libs/gap/element.pyx", line 2645, in sage.libs.gap.element.GapElement_MethodProxy.__call__ (build/cythonized/sage/libs/gap/element.c:27071)
return GapElement_Function.__call__(self, * ([self.first_argument] + list(args)))
File "sage/libs/gap/element.pyx", line 2514, in sage.libs.gap.element.GapElement_Function.__call__ (build/cythonized/sage/libs/gap/element.c:26326)
sig_on()
sage.libs.gap.util.GAPError: Error, no method found! Error, no 1st choice method found for `Representative' on 1 arguments
The 1st argument is 'fail' which might point to an earlier problem
**********************************************************************
Activity
dimpase commentedon Mar 17, 2024
why is gap3 involved here?
is it compared with gap4.13?
tornaria commentedon Mar 17, 2024
tornaria commentedon Mar 17, 2024
@antonio-rojas @kiwifb
dimpase commentedon Mar 18, 2024
It's a bug in the tests there; obviously it should be using gap3 (as it otherwise does not test the implementation in this function!), not gap (i.e. gap4). So we should apply
Otherwise we merely testing what gap4 can do (and what you see is that gap4.13 is broken at this place).
Unfortunately the diff above, with gap3 installed, gives
OTOH gap3 is an experimental package, so this is tolerable (without gap3 installed, there won't be a doctest failure here, after this patch is applied.
dimpase commentedon Mar 18, 2024
I've opened #37624 to fix this little thing - it's quite orthogonal to gap 4.13, so it deserves a separate PR. Please review/approve it.
antonio-rojas commentedon Mar 18, 2024
There's one more failure with
--longantonio-rojas commentedon Mar 18, 2024
LaTeXandLaTeXObjare gone in 4.13 (and there doesn't seem to be a replacement)gap-system/gap#5524
dimpase commentedon Mar 18, 2024
we can use https://gap-packages.github.io/typeset/ I presume
antonio-rojas commentedon May 3, 2024
There's one more failure that only manifests itself if bliss is installed
But it seems to be an upstream issue
gap-system/gap#5708
orlitzky commentedon Jan 19, 2025
We upgraded to GAP 4.13.1 in October.
dimpase commentedon Jan 19, 2025
meanwhile GAP 4.14 is out
tornaria commentedon Jan 19, 2025
For me, it works fine without any further change in sagemath.