Repository navigation
Improve method is_planar - #36021
Merged
Merged
Improve method is_planar#36021
Conversation
Closed
2 tasks done
fchapoton
reviewed
Aug 21, 2023
Collaborator
Author
|
ping |
tscrim
approved these changes
Sep 9, 2023
tscrim
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but could you make one small tweak to the error message outputs and put one extra space on the second line after the break; e.g.,
NotImplementedError: a really long
doctest output line
Once done, you can set a positive review.
Collaborator
Author
|
Thank you for the review. |
|
Documentation preview for this PR (built with commit 933707f; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35152.
We improve the method to avoid working with embeddings when the input (di)graph has multiple edges or loops, or when the input digraph has pairs of opposite arcs. In these cases, the notion of embedding is not consistently defined so far as it mixes neighbors and incident edges.
We now allow to set positions whenever embeddings are not involved.
We also avoid modifying the input graph in method
is_planarfromplanarity.pyxand reorder some operations.📝 Checklist
⌛ Dependencies