Skip to content

Fix the ascii art for the Heisenberg Lie algebras - #36170

Merged
vbraun merged 2 commits into
sagemath:developfrom
tscrim:lie_algebras/heisenberg_ascii_art
Sep 10, 2023
Merged

vbraun merged 2 commits into
sagemath:developfrom
tscrim:lie_algebras/heisenberg_ascii_art

Conversation

@tscrim

@tscrim tscrim commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

Applying ascii_art(x) to any element of the finite-dimensional Heisenberg algebra raises an error due to a missing method _ascii_art_term. We implement this.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton

Copy link
Copy Markdown
Contributor

ok, maybe add an ascii_art(x) doctest ?

@tscrim

tscrim commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator Author

Good idea; I've added it.

@fchapoton fchapoton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go, thanks

@tscrim

tscrim commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator Author

Merci!

@github-actions

github-actions Bot commented Sep 1, 2023

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 098ce29; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 2, 2023
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Applying `ascii_art(x)` to any element of the finite-dimensional
Heisenberg algebra raises an error due to a missing method
`_ascii_art_term`. We implement this.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36170
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 4, 2023
Release Manager
sagemathgh-36170: Fix the ascii art for the Heisenberg Lie algebras
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Applying `ascii_art(x)` to any element of the finite-dimensional
Heisenberg algebra raises an error due to a missing method
`_ascii_art_term`. We implement this.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36170
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 5, 2023
Release Manager
sagemathgh-36170: Fix the ascii art for the Heisenberg Lie algebras
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Applying `ascii_art(x)` to any element of the finite-dimensional
Heisenberg algebra raises an error due to a missing method
`_ascii_art_term`. We implement this.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36170
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
@vbraun
vbraun merged commit 1ebaec7 into sagemath:develop Sep 10, 2023
@tscrim
tscrim deleted the lie_algebras/heisenberg_ascii_art branch September 12, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants