Skip to content

correct upstream_url for libbraiding - #36283

Closed
dimpase wants to merge 0 commit into
sagemath:developfrom
dimpase:develop
Closed

dimpase wants to merge 0 commit into
sagemath:developfrom
dimpase:develop

Conversation

@dimpase

@dimpase dimpase commented Sep 16, 2023

Copy link
Copy Markdown
Member

Package version was hardcoded in upstream_url, and so the update in 94976eb made it uninstallable

@dimpase
dimpase requested a review from mkoeppe September 16, 2023 19:09
@dimpase dimpase changed the title correct upsteam_url for libbraiding correct upstream_url for libbraiding Sep 16, 2023
@dimpase

dimpase commented Sep 16, 2023

Copy link
Copy Markdown
Member Author

turns out the checksums were stale, too.

@mkoeppe

mkoeppe commented Sep 16, 2023

Copy link
Copy Markdown
Contributor

Thanks for fixing this

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkoeppe approved this PR

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 0c689dd; changes) is ready! 🎉

@mkoeppe

mkoeppe commented Nov 26, 2023

Copy link
Copy Markdown
Contributor

@dimpase Somehow this PR fell through the cracks. I've resurrected it in #36781.

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 10, 2023
Release Manager
sagemathgh-36781: `libbraiding`: Actually update to version 1.2
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As previously observed in sagemath#36283, the intended upgrade of libbraiding to
1.2 as part of sagemath#35380 was faulty, and as a result we have a
`libbraiding-1.2.tar.gz` on our mirrors that is actually 1.1.

Here we rectify the situation.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36781
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 17, 2023
Release Manager
sagemathgh-36781: `libbraiding`: Actually update to version 1.2
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As previously observed in sagemath#36283, the intended upgrade of libbraiding to
1.2 as part of sagemath#35380 was faulty, and as a result we have a
`libbraiding-1.2.tar.gz` on our mirrors that is actually 1.1.

Here we rectify the situation.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36781
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants