Repository navigation
Update matplotlib to 3.8.0, pillow to 10.0.1 - #36320
Conversation
|
Documentation preview for this PR (built with commit 86c9580; changes) is ready! 🎉 |
|
On |
|
Build options have changed - https://pillow.readthedocs.io/en/latest/installation.html#build-options |
|
This upgrade unfortunately does not help to fix a build failure with our current matplotlib on latest macOS / Xcode CLT / M2: |
|
Builds for me on Apple M1 with latest OS, command-line tools, homebrew. |
|
Thanks for testing! I am also not able to reproduce the failure mentioned above locally. |
Is the failure specifically conda-related? I am not using conda or mambaforge, just homebrew + CLT. |
| fi | ||
|
|
||
| PILLOW_BUILD_EXT="--debug --disable-jpeg $PILLOW_BUILD_EXT" | ||
| PILLOW_CONFIG_SETTINGS="-C debug=true -C jpeg=disable $PILLOW_CONFIG_SETTINGS" |
There was a problem hiding this comment.
It builds (on OS X) without -C debug=true; can we delete it? I can't tell from the documentation how this option might be useful in the Sage build.
There was a problem hiding this comment.
I think it is useful to diagnose build problems.
Yes, the |
|
Okay, let's merge it. |
sagemathgh-36509: meson 1.2.3, numpy 1.26.1, require meson >= 1.2.0 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The increased lower bound for meson is for contourpy, which was updated in sagemath#36320. ubuntu-mantic https://github.com/sagemath/sage/actions/runs/6645713841/j ob/18057705190?pr=36541#step:10:2162 ``` [contourpy-1.1.1] ../meson.build:10:17: ERROR: Meson version is 1.1.1 but project requires >= 1.2.0 ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36509 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
sagemathgh-36509: meson 1.2.3, numpy 1.26.1, require meson >= 1.2.0 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> The increased lower bound for meson is for contourpy, which was updated in sagemath#36320. ubuntu-mantic https://github.com/sagemath/sage/actions/runs/6645713841/j ob/18057705190?pr=36541#step:10:2162 ``` [contourpy-1.1.1] ../meson.build:10:17: ERROR: Meson version is 1.1.1 but project requires >= 1.2.0 ``` <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36509 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
📝 Checklist
⌛ Dependencies