Skip to content

fix doctest in src/sage/combinat/posets/posets.py - #36464

Merged
vbraun merged 1 commit into
sagemath:developfrom
dcoudert:posets/fix_failing_doctest
Oct 21, 2023
Merged

vbraun merged 1 commit into
sagemath:developfrom
dcoudert:posets/fix_failing_doctest

Conversation

@dcoudert

Copy link
Copy Markdown
Collaborator

The following doctest in `sage/combinat/posets/posets.py" is failing on some systems, e.g., here on fedora 35.

sage -t --long --warn-long 14.4 --random-seed=28988349073943040517554297060681045316 src/sage/combinat/posets/posets.py
**********************************************************************
File "src/sage/combinat/posets/posets.py", line 1374, in sage.combinat.posets.posets.FinitePoset._latex_
Failed example:
    print(P._latex_())  # optional - dot2tex graphviz
Expected:
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_...) at (5...bp,...bp) [draw,draw=none] {$...$};
      \node (node_...) at (5...bp,...bp) [draw,draw=none] {$...$};
      \draw [black,->] (node_...) ..controls (...bp,...bp) and (...bp,...bp)  .. (node_...);
    %
    \end{tikzpicture}
Got:
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_0) at (6.0bp,6.5bp) [draw,draw=none] {$1$};
      \node (node_1) at (6.0bp,55.5bp) [draw,draw=none] {$2$};
      \draw [black,->] (node_0) ..controls (6.0bp,19.603bp) and (6.0bp,30.062bp)  .. (node_1);
    %
    \end{tikzpicture}

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 17, 2023
Release Manager
sagemathgh-36464: fix doctest in `src/sage/combinat/posets/posets.py`
    
The following doctest in `sage/combinat/posets/posets.py" is failing on
some systems, e.g., here on fedora 35.

```py
sage -t --long --warn-long 14.4 --random-
seed=28988349073943040517554297060681045316
src/sage/combinat/posets/posets.py
**********************************************************************
File "src/sage/combinat/posets/posets.py", line 1374, in
sage.combinat.posets.posets.FinitePoset._latex_
Failed example:
    print(P._latex_())  # optional - dot2tex graphviz
Expected:
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_...) at (5...bp,...bp) [draw,draw=none] {$...$};
      \node (node_...) at (5...bp,...bp) [draw,draw=none] {$...$};
      \draw [black,->] (node_...) ..controls (...bp,...bp) and
(...bp,...bp)  .. (node_...);
    %
    \end{tikzpicture}
Got:
    \begin{tikzpicture}[>=latex,line join=bevel,]
    %%
    \node (node_0) at (6.0bp,6.5bp) [draw,draw=none] {$1$};
      \node (node_1) at (6.0bp,55.5bp) [draw,draw=none] {$2$};
      \draw [black,->] (node_0) ..controls (6.0bp,19.603bp) and
(6.0bp,30.062bp)  .. (node_1);
    %
    \end{tikzpicture}
```
### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36464
Reported by: David Coudert
Reviewer(s): Kwankyu Lee
@vbraun
vbraun merged commit 433e825 into sagemath:develop Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants