Skip to content

Fix bootstrapping on centos-7, fedora-30, ubuntu-xenial - #36476

Merged
vbraun merged 1 commit into
sagemath:developfrom
mkoeppe:sage_bootstrap_py2
Oct 21, 2023
Merged

vbraun merged 1 commit into
sagemath:developfrom
mkoeppe:sage_bootstrap_py2

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Oct 17, 2023 •

Copy link
Copy Markdown
Contributor

On centos-7, still supported until June 2024, we have to use sage-bootstrap-python = python2.
Support for Python 2 was broken accidentally in #36393, see https://github.com/sagemath/sage/actions/runs/6520548150/job/17767608828#step:10:1927

Fixed here, as tested with tox -e docker-centos-7-devtoolset-gcc_11-standard -- config.status.

Same issue also affects fedora-30, which is still tested by the CI as a proxy for old RHEL, and ubuntu-xenial. See #32074

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well (the macos conda workflow had the same issue, but bootstrap is working there now).

@mkoeppe

mkoeppe commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

@vbraun
vbraun merged commit c47788b into sagemath:develop Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants