Skip to content

CI Linux: Fix centos-7 after #36435, remove gentoo-python3.12 for now, use conda-forge with -python3.11 - #36534

Merged
vbraun merged 5 commits into
sagemath:developfrom
mkoeppe:ci_linux_platforms
Nov 10, 2023
Merged

vbraun merged 5 commits into
sagemath:developfrom
mkoeppe:ci_linux_platforms

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Oct 25, 2023 •

Copy link
Copy Markdown
Contributor

As part of the changes in #36435, we switched from http to https for downloading mirror_list.
This broke centos-7; here we fix it.

gentoo-python3.12 was activated a little bit too early. We remove it to clean up the portability CI workflow.

conda-forge defaults to 3.12 already, and we're not ready for it.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions

github-actions Bot commented Nov 2, 2023

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 1d2231b; changes) is ready! 🎉

@kwankyu

kwankyu commented Nov 4, 2023 •

Copy link
Copy Markdown
Collaborator

tox -e docker-centos-7-standard doesn't work for me on mac:

...
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
...

I am running Docker Desktop. Is tox.ini supposed to run on linux only?

@mkoeppe

mkoeppe commented Nov 4, 2023

Copy link
Copy Markdown
Contributor Author

No, I use it on macOS. Check using which docker where your Docker client is coming from

@kwankyu

kwankyu commented Nov 4, 2023

Copy link
Copy Markdown
Collaborator

Thanks. Solved by checking Allow the default Docker socket to be used (requires password) in Settings.

@kwankyu

kwankyu commented Nov 5, 2023

Copy link
Copy Markdown
Collaborator

Now stuck at

SAGE_PKGCONFIG=/sage/local/lib/pkgconfig
SAGE_ROOT=/sage
SAGE_SHARE=/sage/local/share
SAGE_SILENT_BUILD=yes
SAGE_SRC=/sage/src
SHLVL=4
USE_MAKEFLAGS=-k V=0
V=0
_=/usr/bin/env
***********************************************
make[1]: Entering directory `/sage/build/make'
touch /sage/local/var/lib/sage/installed/.dummy
make --no-print-directory toolchain
make --no-print-directory gmp-SAGE_LOCAL-no-deps
make --no-print-directory zlib-SAGE_LOCAL-no-deps
[zlib-1.2.11.p0] installing. Log file: /sage/logs/pkgs/zlib-1.2.11.p0.log
[gmp-6.2.1] installing. Log file: /sage/logs/pkgs/gmp-6.2.1.log
  [zlib-1.2.11.p0] successfully installed.
  [gmp-6.2.1] successfully installed.
make --no-print-directory mpfr-SAGE_LOCAL-no-deps
[mpfr-4.0.1.p0] installing. Log file: /sage/logs/pkgs/mpfr-4.0.1.p0.log
  [mpfr-4.0.1.p0] successfully installed.
make --no-print-directory mpc-SAGE_LOCAL-no-deps
[mpc-1.1.0] installing. Log file: /sage/logs/pkgs/mpc-1.1.0.log
  [mpc-1.1.0] successfully installed.
make --no-print-directory gcc-SAGE_LOCAL-no-deps
[gcc-12.2.0] installing. Log file: /sage/logs/pkgs/gcc-12.2.0.log
(pending forever...)

@kwankyu

kwankyu commented Nov 5, 2023 •

Copy link
Copy Markdown
Collaborator

But that seems an issue just with me. Perhaps not related with what's done here.

@kwankyu kwankyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mkoeppe

mkoeppe commented Nov 5, 2023

Copy link
Copy Markdown
Contributor Author

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 6, 2023
…ve `gentoo-python3.12` for now, use `conda-forge` with `-python3.11`

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As part of the changes in sagemath#36435, we switched from http to https for
downloading mirror_list.
This broke centos-7; here we fix it.

gentoo-python3.12 was activated a little bit too early. We remove it to
clean up the portability CI workflow.

conda-forge defaults to 3.12 already, and we're not ready for it.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36534
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 7, 2023
Release Manager
sagemathgh-36534: CI Linux: Fix `centos-7` after sagemath#36435, remove `gentoo-python3.12` for now, use `conda-forge` with `-python3.11`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
As part of the changes in sagemath#36435, we switched from http to https for
downloading mirror_list.
This broke centos-7; here we fix it.

gentoo-python3.12 was activated a little bit too early. We remove it to
clean up the portability CI workflow.

conda-forge defaults to 3.12 already, and we're not ready for it.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36534
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun
vbraun merged commit 31a1ae5 into sagemath:develop Nov 10, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 12, 2023
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The fix in sagemath#36534 was not complete. The job was named as intended conda-
forge-python3.11, but it was still using 3.12, which failed in
https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581

Fixed here, as tested with `tox -e docker-conda-forge-
python3.11-standard -- config.status`

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36699
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 14, 2023
Release Manager
sagemathgh-36699: CI Linux: Follow-up fix for conda-forge-python3.11
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The fix in sagemath#36534 was not complete. The job was named as intended conda-
forge-python3.11, but it was still using 3.12, which failed in
https://github.com/sagemath/sage/actions/runs/6827163299/job/18568706581

Fixed here, as tested with `tox -e docker-conda-forge-
python3.11-standard -- config.status`

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36699
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants