Skip to content

Support giac 1.9.0-67 - #36600

Merged
vbraun merged 1 commit into
sagemath:developfrom
tornaria:giac-1.9.0-67
Nov 5, 2023
Merged

vbraun merged 1 commit into
sagemath:developfrom
tornaria:giac-1.9.0-67

Conversation

@tornaria

Copy link
Copy Markdown
Member

The function gb_giac() is less noisy, so we adjust doctests in a way they accept the noisy version (old giac) but don't fail with the silent version (new giac).

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 57f27a0; changes) is ready! 🎉

@orlitzky

Copy link
Copy Markdown
Contributor

Running testlong now, back in about 24h.

@antonio-rojas

Copy link
Copy Markdown
Member

LGTM

@kiwifb

kiwifb commented Oct 31, 2023

Copy link
Copy Markdown
Member

Does LGTM too. It is nice that giac is less chatty when used as a library. Still need to get those blank lines out though.

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 1, 2023
Release Manager
sagemathgh-36600: Support giac 1.9.0-67
    
The function `gb_giac()` is less noisy, so we adjust doctests in a way
they accept the noisy version (old giac) but don't fail with the silent
version (new giac).

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36600
Reported by: Gonzalo Tornaría
Reviewer(s):

@orlitzky orlitzky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added giac-1.9.0.67 to Gentoo and ran the full test suite. This does fix the only new issues, thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 2, 2023
Release Manager
sagemathgh-36600: Support giac 1.9.0-67
    
The function `gb_giac()` is less noisy, so we adjust doctests in a way
they accept the noisy version (old giac) but don't fail with the silent
version (new giac).

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#36600
Reported by: Gonzalo Tornaría
Reviewer(s): Michael Orlitzky
@vbraun
vbraun merged commit d0b1490 into sagemath:develop Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants