Skip to content

prompt_toolkit: Set version constraint for conda - #36659

Merged
vbraun merged 1 commit into
sagemath:developfrom
mkoeppe:prompt_toolkit_conda
Nov 10, 2023
Merged

vbraun merged 1 commit into
sagemath:developfrom
mkoeppe:prompt_toolkit_conda

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

Replaces #36560.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 7dabb0a; changes) is ready! 🎉

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only in the conda file and not also in install_requires?

@mkoeppe

mkoeppe commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

Because it's already there

@dimpase dimpase left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe

mkoeppe commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

@vbraun
vbraun merged commit 781dbff into sagemath:develop Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants