Repository navigation
avoid using numpy in graphs.RandomBipartite - #42767
Merged
vbraun merged 6 commits intoOct 18, 2026
Merged
Conversation
|
Documentation preview for this PR (built with commit 284d1a0; changes) is ready! 🎉 |
5 tasks done
Contributor
|
ca depend d'une autre PR ? |
Collaborator
Author
fchapoton
reviewed
Sep 9, 2026
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 16, 2026
sagemathgh-42767: avoid using numpy in `graphs.RandomBipartite` This PR replaces a the call to `numpy.uniform` by a call to `random` in `RandomBipartite`. This ease the setting of the random seed. This way we avoid the need for several `# needs numpy`. On the way we add parameter `seed` to methods `HoffmanSingletonGraph` and `SylvesterGraph` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#42767 Reported by: David Coudert Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
that referenced
this pull request
Oct 22, 2026
gh-41886: test parameter `immutable` for most graph generators As discussed in #41501 (comment), we add tests for checking the behavior of parameter `immutable` on many graph generators. Tests for distance regular graphs will be added when #41723 and #41725 will be merged and some final work is done on this file. Tests for trees will be added after #41714. On the way, we take parameter `immutable` into account in `RingedTree` when `vertex_labels` is `False`. For each graph constructor, we compare the graphs obtained with parameter immutable set to `True` and `False`. We check that these graphs have the same set of vertices and edges. This is faster than graph isomorphism and certainly sufficient. The tests we use support graphs with different types of vertex labels. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies #42767 <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #41886 Reported by: David Coudert Reviewer(s): Martin Rubey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces a the call to
numpy.uniformby a call torandominRandomBipartite. This ease the setting of the random seed. This way we avoid the need for several# needs numpy.On the way we add parameter
seedto methodsHoffmanSingletonGraphandSylvesterGraph📝 Checklist
⌛ Dependencies