Repository navigation
Added alias to_integer for lift - #42811
Conversation
|
Documentation preview for this PR (built with commit 5bd2e69; changes) is ready! 🎉 |
|
I have checked the documentation in the latest commit in the pdf version. I'm not sure why the html-version doesn't work, but it failed on "downloading old doc". |
Can you edit this to use the wording "Fixes #42799" so that GitHub will link this PR to the issue and close the issue when this PR is merged?
Detailed tests definitely are not needed. You could have one test just to make sure the alias works, but I'm fine with it either way. |
|
Doc build failure is odd, I think it's spurious and should hopefully go away in the next run. |
Co-authored-by: Vincent Macri <vincent.macri@ucalgary.ca>
|
Looks good to me! Just a heads up, since we're now on release candidates for 10.10 it might be some time before this gets merged into develop as I think we only merge critical fixes at this point of a release cycle. I expect this will get merged in for the first 10.11 beta release. In the meantime, just keep an eye on this branch and resolve any merge conflicts if they arise (i.e. if GitHub stops saying "Changes can be cleanly merged"). |
Fixes #42799 .$$\mathbb{Z}/n\mathbb{Z}$$ rings) solves the problem, since the behaviour of
I added under the
_integer_alias forlift()also the aliasto_integer().Finite fields of prime order are integer mod n objects in Sage. This caused the function
to_integer()of finite fields to fail on fields of prime order.Adding
to_integer()as an alias for lift (which makes sense in allto_integer()on finite fields of prime order should be the same as that oflift.(Since it is an alias, tests did not seem to be relevant, but I like to hear if that is not true.)
📝 Checklist
⌛ Dependencies
no dependencies