Repository navigation
Move -W flag in Mac OS X - #42853
Merged
Merged
Move -W flag in Mac OS X#42853
Conversation
|
Documentation preview for this PR (built with commit 5781710; changes) is ready! 🎉 |
trevorkarn
marked this pull request as ready for review
September 25, 2026 00:29
Contributor
Author
|
The only failing tests are ubuntu which is explicitly not touched by these Mac OS X changes. |
|
I tried this on an Intel mac with macos 26.6.2, and it worked (I was able to interact with sage after opening the documentation) |
Collaborator
|
How do you open the doc from the command line? |
|
I believe there is an orthogonal issue that makes |
kwankyu
approved these changes
Sep 28, 2026
kwankyu
left a comment
Collaborator
There was a problem hiding this comment.
OK. Anyway, the change was verified on a Mac. The code looks good to me.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the browser is opened from Sage in Mac OS X causes the command line interface to hang until the browser is entirely closed. The proposed fix is to just remove the flag that causes the process to hang until the browser window is closed.
📝 Checklist
⌛ Dependencies