Skip to content

Move -W flag in Mac OS X - #42853

Merged
vbraun merged 2 commits into
sagemath:developfrom
trevorkarn:viewer-darwin
Sep 29, 2026
Merged

vbraun merged 2 commits into
sagemath:developfrom
trevorkarn:viewer-darwin

Conversation

@trevorkarn

Copy link
Copy Markdown
Contributor

The way the browser is opened from Sage in Mac OS X causes the command line interface to hang until the browser is entirely closed. The proposed fix is to just remove the flag that causes the process to hang until the browser window is closed.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 5781710; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@trevorkarn
trevorkarn marked this pull request as ready for review September 25, 2026 00:29
@trevorkarn

Copy link
Copy Markdown
Contributor Author

The only failing tests are ubuntu which is explicitly not touched by these Mac OS X changes.

@aldenwalker

Copy link
Copy Markdown

I tried this on an Intel mac with macos 26.6.2, and it worked (I was able to interact with sage after opening the documentation)

@kwankyu

kwankyu commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

How do you open the doc from the command line? manual() does not work for me. I installed sage by make doc.

@aldenwalker

Copy link
Copy Markdown

I believe there is an orthogonal issue that makes manual() not work, although I thought it was an issue only with a pip build. I think @trevorkarn knows more.

@kwankyu kwankyu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Anyway, the change was verified on a Mac. The code looks good to me.

@trevorkarn

Copy link
Copy Markdown
Contributor Author

@kwankyu - for the manual() issue, see #42854

@vbraun
vbraun merged commit 684240b into sagemath:develop Sep 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants