Skip to content

make sure the 176-vertex SRG construction uses no loops - #42869

Merged
vbraun merged 1 commit into
sagemath:developfrom
dimpase:noloops
Oct 3, 2026
Merged

vbraun merged 1 commit into
sagemath:developfrom
dimpase:noloops

Conversation

@dimpase

@dimpase dimpase commented Sep 29, 2026

Copy link
Copy Markdown
Member

as reported on [sage-develop]
(https://groups.google.com/g/sage-release/c/eEqcgIoqchM/m/fEwLBJf7AAAJ)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit df26b08; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert dcoudert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeriedel24

Copy link
Copy Markdown
Contributor

Thank you for this fix.
Since you ask, in the above-mentioned thread in the sage-release group, why this failure does not show up on other platforms:
It does show up in my installation of Sage 10.10.rc0 on Almalinux 9.8 x86_64 with Python 3.14.7, and your fix also works there.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 1, 2026
Release Manager
sagemathgh-42869: make sure the 176-vertex SRG construction uses no loops
    
as reported on [sage-develop]
(https://groups.google.com/g/sage-release/c/eEqcgIoqchM/m/fEwLBJf7AAAJ)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#42869
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 3, 2026
Release Manager
sagemathgh-42869: make sure the 176-vertex SRG construction uses no loops
    
as reported on [sage-develop]
(https://groups.google.com/g/sage-release/c/eEqcgIoqchM/m/fEwLBJf7AAAJ)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#42869
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
@vbraun
vbraun merged commit aeb5f21 into sagemath:develop Oct 3, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants