Repository navigation
Accept Python int in ZZ.quotient - #42942
Merged
vbraun merged 3 commits intoOct 18, 2026
Merged
Conversation
vincentmacri
requested changes
Oct 9, 2026
vincentmacri
left a comment
Member
There was a problem hiding this comment.
Remove some superfluous doctests and prefer the syntax 1r instead of int(1) for doctests. int(1) translated to the Python code int(Integer(1)) and 1r translates to the Python code 1. So the int call you currently have is adding extra unrelated type conversions to the test.
Member
|
Looks good otherwise! |
Contributor
Author
|
Thanks for the review @vincentmacri |
|
Documentation preview for this PR (built with commit 3f20229; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 16, 2026
sagemathgh-42942: Accept Python int in ZZ.quotient <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#42933 This PR allows Python `int` values as input to `IntegerRing_class.quotient()`. Previously, passing a Python integer raised a `TypeError`, because the method only accepted Sage `Integer` objects, while `Zmod(int(n))` already worked. The fix converts Python integers to Sage `Integer` objects before proceeding with the existing logic. Doctests are added to verify support for positive, zero, and negative integers, and to confirm that floating-point inputs are still rejected. AI disclosure: I used an AI assistant Claude to help understand the issue, draft the doctests . I reviewed everything and ran the doctests locally (232 passed). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#42942 Reported by: Shubhankar Joshi Reviewer(s): Vincent Macri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42933
This PR allows Python
intvalues as input toIntegerRing_class.quotient().Previously, passing a Python integer raised a
TypeError, because the methodonly accepted Sage
Integerobjects, whileZmod(int(n))already worked.The fix converts Python integers to Sage
Integerobjects before proceedingwith the existing logic. Doctests are added to verify support for positive,
zero, and negative integers, and to confirm that floating-point inputs are
still rejected.
AI disclosure: I used an AI assistant Claude to help understand the issue, draft the doctests . I reviewed everything and ran the doctests locally (232 passed).
📝 Checklist
⌛ Dependencies