Skip to content

Accept Python int in ZZ.quotient - #42942

Merged
vbraun merged 3 commits into
sagemath:developfrom
Shubhankar-Joshi2489:fix-zz-quotient-int
Oct 18, 2026
Merged

vbraun merged 3 commits into
sagemath:developfrom
Shubhankar-Joshi2489:fix-zz-quotient-int

Conversation

@Shubhankar-Joshi2489

@Shubhankar-Joshi2489 Shubhankar-Joshi2489 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #42933

This PR allows Python int values as input to IntegerRing_class.quotient().
Previously, passing a Python integer raised a TypeError, because the method
only accepted Sage Integer objects, while Zmod(int(n)) already worked.

The fix converts Python integers to Sage Integer objects before proceeding
with the existing logic. Doctests are added to verify support for positive,
zero, and negative integers, and to confirm that floating-point inputs are
still rejected.

AI disclosure: I used an AI assistant Claude to help understand the issue, draft the doctests . I reviewed everything and ran the doctests locally (232 passed).

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@vincentmacri vincentmacri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove some superfluous doctests and prefer the syntax 1r instead of int(1) for doctests. int(1) translated to the Python code int(Integer(1)) and 1r translates to the Python code 1. So the int call you currently have is adding extra unrelated type conversions to the test.

Comment thread src/sage/rings/integer_ring.pyx Resolved
Comment thread src/sage/rings/integer_ring.pyx Resolved
@vincentmacri

Copy link
Copy Markdown
Member

Looks good otherwise!

@Shubhankar-Joshi2489

Copy link
Copy Markdown
Contributor Author

Thanks for the review @vincentmacri

@github-actions

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 3f20229; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 16, 2026
Release Manager
sagemathgh-42942: Accept Python int in ZZ.quotient
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#42933

This PR allows Python `int` values as input to
`IntegerRing_class.quotient()`.
Previously, passing a Python integer raised a `TypeError`, because the
method
only accepted Sage `Integer` objects, while `Zmod(int(n))` already
worked.

The fix converts Python integers to Sage `Integer` objects before
proceeding
with the existing logic. Doctests are added to verify support for
positive,
zero, and negative integers, and to confirm that floating-point inputs
are
still rejected.

AI disclosure: I used an AI assistant Claude  to help understand the
issue, draft the doctests .   I reviewed everything and ran the doctests
locally (232 passed).

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#42942
Reported by: Shubhankar Joshi
Reviewer(s): Vincent Macri
@vbraun
vbraun merged commit 078f1b2 into sagemath:develop Oct 18, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZZ.quotient rejects Python int arguments

3 participants