Repository navigation
Enable use of from __future__ import annotations for ruff diagnostics - #42996
Merged
Merged
Conversation
|
Documentation preview for this PR (built with commit ca9c15e; changes) is ready! 🎉 |
Member
|
Document ruff ignore Ruff ignore
vincentmacri
force-pushed
the
future_import
branch
from
October 19, 2026 17:18
f0aaa8d to
ca9c15e
Compare
vincentmacri
marked this pull request as ready for review
October 19, 2026 17:49
starnotes-xj
added a commit
to starnotes-xj/sage
that referenced
this pull request
Oct 29, 2026
The Lint job (ruff with --preview) flags the annotation-only CategoryObject import, and PlusInfinity has become an unused import. Enable module-level postponed annotations (per sagemathgh-42996, which enabled them for ruff diagnostics), move CategoryObject into the TYPE_CHECKING block, and drop the orphaned PlusInfinity import. The probe still executes cleanly.
starnotes-xj
added a commit
to starnotes-xj/sage
that referenced
this pull request
Nov 10, 2026
The Lint job (ruff with --preview) flags the annotation-only CategoryObject import, and PlusInfinity has become an unused import. Enable module-level postponed annotations (per sagemathgh-42996, which enabled them for ruff diagnostics), move CategoryObject into the TYPE_CHECKING block, and drop the orphaned PlusInfinity import. The probe still executes cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable a setting for ruff to add
from __future__ import annotationswhere doing so would simplify/improve code, and fix the new resulting linter violations.📝 Checklist
⌛ Dependencies