Repository navigation
cython-lint fixes in function_field/ - #43025
Conversation
|
Documentation preview for this PR (built with commit ff72b9e; changes) is ready! 🎉 |
vincentmacri
left a comment
There was a problem hiding this comment.
Consider disabling whatever linter rule suggested _i, but otherwise this is good. If you feel strongly about using _i, feel free to set to positive review yourself.
|
Not sure why my suggested changes are rendering funny in GitHub. |
|
Test failures are relevant |
|
Maybe just revert 6bac29a and merge if CI is green. I remember when I was writing this code originally that I was pushing what the Cython compiler was able to understand (by which I mean, this code was written very carefully to avoid Cython compiler bugs/missing features). So whatever esoteric error we're getting right now probably isn't worth the effort to investigate. |
863b572 to
ff72b9e
Compare
small changes as suggested by
cython-lintin thefunction_fieldfolder📝 Checklist