Skip to content

cython-lint fixes in function_field/ - #43025

Merged
vbraun merged 1 commit into
sagemath:developfrom
fchapoton:cylint_funfield
Oct 28, 2026
Merged

vbraun merged 1 commit into
sagemath:developfrom
fchapoton:cylint_funfield

Conversation

@fchapoton

@fchapoton fchapoton commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

small changes as suggested by cython-lint in the function_field folder

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Documentation preview for this PR (built with commit ff72b9e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vincentmacri vincentmacri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider disabling whatever linter rule suggested _i, but otherwise this is good. If you feel strongly about using _i, feel free to set to positive review yourself.

@vincentmacri

Copy link
Copy Markdown
Member

Not sure why my suggested changes are rendering funny in GitHub.

@dcoudert dcoudert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vincentmacri

Copy link
Copy Markdown
Member

Test failures are relevant

@vincentmacri

vincentmacri commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Maybe just revert 6bac29a and merge if CI is green. I remember when I was writing this code originally that I was pushing what the Cython compiler was able to understand (by which I mean, this code was written very carefully to avoid Cython compiler bugs/missing features). So whatever esoteric error we're getting right now probably isn't worth the effort to investigate.

@vbraun
vbraun merged commit 41e9d4e into sagemath:develop Oct 28, 2026
24 checks passed
@fchapoton
fchapoton deleted the cylint_funfield branch October 29, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants