Repository navigation
add missing include directives for compiling with Clang 23 - #43027
Merged
Merged
Conversation
Contributor
|
Thanks for backporting those changes to Sage. :) That saved me the work of opening another pull request. :D |
striezel
approved these changes
Oct 20, 2026
Collaborator
Author
|
Thanks. I'm adding label "positive review" on your behalf. |
|
Documentation preview for this PR (built with commit 8cb016a; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a back port of passagemath/passagemath#2961 that adds missing
#include <iterator>directives to fix compilation errors with Clang 23.Both
std::back_inserterandstd::insert_iteratorare part ofiterator.We add the missing include directive in
data.cc,boost_interface.cppandmodular_decomposition.hpp.This is not needed for
src/sage/symbolic/ginac/ex_utils.hwhich includessrc/sage/symbolic/ginac/ex.hwhich already contains#include <iterator>.On the way we fix 2 compilation warnings in
src/sage/geometry/triangulation/data.cc📝 Checklist
⌛ Dependencies