Repository navigation
src/sage/rings/qqbar.py: implement complex appoximations using float() - #43028
Merged
Merged
Conversation
We have a more careful implementation of float() now that will not return a non-zero approximation to an exact zero element.
The __complex__() method is now a small improvement over CC(), so use the former to implement _complex_double_().
|
Documentation preview for this PR (built with commit 7f0b2b3; changes) is ready! 🎉 |
Change 0.6324555320336758j to 0.6324555320336759j, which, unarguably, is more j.
Contributor
|
Thank you. I will review this later |
cxzhong
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__float__()method inAAwas recently rewritten so that it will not approximate an exactly-zero element with a non-zero floating point. The previous implementation punted toRR()and could not make the same promise.This PR makes the same improvement to the
__complex__()and_complex_double_()methods by using the float approximation of the real and imaginary parts instead of punting toCC().See also: