Repository navigation
Update minimum dependencies in accordance with SPEC 0 - #43031
Conversation
Ignore another rule ignore redundant condition Another ty ignore
|
Documentation preview for this PR (built with commit bfca887; changes) is ready! 🎉 |
|
Due to https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576 I am increasing the priority of this to blocker as conda refuses to resolve with the current version of |
|
@codex review |
|
trying something now, sorry :-) |
tobiasdiez
left a comment
There was a problem hiding this comment.
Only small nitpik, otherwise looks good. Thanks a lot for this PR!
| 'mpmath >=1.1.0', | ||
| 'networkx >=3.5', | ||
| 'numpy >=1.25', | ||
| 'numpy >=2.2.24', |
There was a problem hiding this comment.
Could you also please use the same constraints in the requires section above. Thanks!
There was a problem hiding this comment.
I realized I didn't bump the minimum dependencies as much as I should have. I've bumped all the numpy constraints to >= 2.3.0 and also bumped a few more dependencies further.
|
do we need to update uv.lock too? |
Yes. Whether I can get that to work is a separate issue, but I will try. Before the CA issue I was happy to leave the |
|
We should bump |
| content = f.read() | ||
| f.seek(0, 0) | ||
| # Override conda's cysignals after solving its dependencies; | ||
| # conda-forge does not yet provide Sage's cysignals release. |
There was a problem hiding this comment.
Newest cysignals is available in conda-forge now thanks to @saraedum.
|
|
|
I had to remove |
It needs sagemath/sage-numerical-backends-coin#11 and a release. (It should only be emitting a deprecation warning, but it hasn't had a release since the last time @dimpase fixed setup.py) |
In that case I suggest we leave it commented out in the |
|
Yeah, I didn't even know it was in there, fine with me. |
dimpase
left a comment
There was a problem hiding this comment.
I'll leave it commented out. I have an old PR to move it back into the sage tree, which is held by the macOS openmp PR, which hopefully gets in real soon...
gh-43034: build/pkgs: update certifi and pip for the emSign CA security incident Depends on #43031. Update Sage's certifi spkg from **2026.2.25 to 2026.10.19** and pip from **26.0.1 to 26.2.2**, including their wheel checksums, to address the compromised eMudhra/emSign intermediate CAs. The corrected certifi bundle removes the affected emSign ECC G3 root while retaining unaffected emSign roots. pip must also be updated because it vendors its own certifi bundle. These are the versions recommended in the [Python security announcement](https://discuss.python.org/t/information-for-python-users- regarding-emudhra-emsign-ca-certificate-security-incident/109576); see also [GHSA-6q48-6c7w-9gw2](https://github.com/certifi/python- certifi/security/advisories/GHSA-6q48-6c7w-9gw2). This branch is based on #43031, which supplies the conda environment and `uv.lock` security updates and disables the optional COIN backend. The additional diff here is limited to the certifi and pip spkg versions and checksums. Installations using system packages still depend on their distribution's security updates. Validation: - Verified the wheel hashes against PyPI and passed Sage's checksum verification for both packages. - Previously installed both wheels offline in a fresh Python 3.14 environment; `pip check` passed, and both certificate bundles omit the affected G3 root while retaining the unaffected emSign roots. - After rebasing, `uv lock --check --offline` passes against the repository's `pyproject.toml`. - Confirmed all ten conda environments and `uv.lock` retain the fixed certifi, pip, and uv versions; conda also retains the fixed ca- certificates release. - `git diff --check` passes. Full conda environments and Sage were not rebuilt. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - #43031 URL: #43034 Reported by: Dima Pasechnik Reviewer(s): Marc Culler
Drop support for old dependencies according to SPEC 0 and update the conda lock files accordingly. In the process of updating the conda lock files, a new version of
tywas pulled in with new diagnostics that I added to the ignore list inpyproject.tomlbecause fixing them is out of scope for this PR.This PR was partly done in order to minimize the diffs for when we eventually get a PR submitted that adds Python 3.15 support, since that will involve regenerating the lock files as well. By pure coincidence this PR is perfectly timed to deal with https://discuss.python.org/t/information-for-python-users-regarding-emudhra-emsign-ca-certificate-security-incident/109576
📝 Checklist
⌛ Dependencies