Skip to content

Update meataxe to 1.0.3 and use upstream arithmetic table installation - #43040

Merged
vbraun merged 2 commits into
sagemath:developfrom
dimpase:meataxe-1.0.3
Oct 28, 2026
Merged

vbraun merged 2 commits into
sagemath:developfrom
dimpase:meataxe-1.0.3

Conversation

@dimpase

@dimpase dimpase commented Oct 23, 2026

Copy link
Copy Markdown
Member

Update the optional meataxe package from 1.0.2 to SharedMeatAxe 1.0.3, including the SHA-1 and SHA-256 checksums of its published configured source archive. This release fixes parallel tests with a configured arithmetic table directory.

Enable upstream table generation and installation with --enable-tables, using MTXLIB when set and $SAGE_SHARE/meataxe otherwise. Remove the manual spkg-postinst.in generation loop: tables are now installed during make install, including for staged installations, and the GF(256) table is included.

Validation:

  • sage-package fix-checksum meataxe confirms that the checksums match the downloaded release archive.
  • Ran the updated spkg-install.in and existing spkg-check.in with Sage's actual distribution helpers, both with the default table directory and with a custom MTXLIB plus SAGE_DESTDIR; all 26 upstream tests pass in each configuration.
  • Verified installation of all 70 prime-power tables through GF(256), package metadata, and GF(256) matrix conversion with read-only tables.
  • bash -n and git diff --check pass.

Full Sage doctests were not run: the local editable Sage installation requires an unrelated rebuild.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

None.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Documentation preview for this PR (built with commit 58a8b05; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@jeriedel24

Copy link
Copy Markdown
Contributor

This PR causes a small error in a doctest in sage/matrix/matrix_gfpn_dense.pyx, line 456.
The MeatAxe function MatLoad (called in line 473) returns the error message No such file or directory in file os.c (line 255) with MeatAxe 1.0.2, but that line number is 259 with MeatAxe 1.0.3.

I have not found any other doctest failures which are caused by the MeatAxe update.

@dimpase

dimpase commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

This PR causes a small error in a doctest in sage/matrix/matrix_gfpn_dense.pyx, line 456. The MeatAxe function MatLoad (called in line 473) returns the error message No such file or directory in file os.c (line 255) with MeatAxe 1.0.2, but that line number is 259 with MeatAxe 1.0.3.

I have not found any other doctest failures which are caused by the MeatAxe update.

Thanks for testing. Can you do a PR against this branch on my fork to fix the doctest?

@jeriedel24

jeriedel24 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Well, I have just opened PR #21 on your fork but my GIT knowledge is apparently not sufficient to get this PR right.
It says that I want to merge 335 commits which is not my intention. I just want to merge one commit for sage/matrix/matrix_gfpn_dense.pyx.
Could you please give me a hint how I can get this PR right?
My commit is 605e239 at the end of the list of 335 commits.

@dimpase

dimpase commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

@jeriedel24 your pr should have have dimpase:meataxe-1.0.3 as base branch, not dimpase: develop

this is something you can fix by clicking on "edit" next to the PR title and choosing the correct branch

@jeriedel24

Copy link
Copy Markdown
Contributor

@dimpase thank you for your hint. I have done as suggested.

@vbraun
vbraun merged commit 6df79bf into sagemath:develop Oct 28, 2026
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants