Skip to content
This repository was archived by the owner on Jun 18, 2026. It is now read-only.

Use kubernetes.io/os label for node selector - #789

Merged
hvaghani221 merged 1 commit into
splunk:developfrom
vinzent:feature/node-selector-beta-kuber-netes-io-os-deprecated
Jul 29, 2022
Merged

hvaghani221 merged 1 commit into
splunk:developfrom
vinzent:feature/node-selector-beta-kuber-netes-io-os-deprecated

Conversation

@vinzent

@vinzent vinzent commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

According warnig messages printed by K8s 1.22, the old label
beta.kubernetes.io/os is deprecated since 1.14.

Message printed by kubectl:

W0714 15:21:21.896079 2914669 warnings.go:70] spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Not sure what type of change this is. :-)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have read the CLA
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

According warnig messages printed by K8s 1.22, the old label
`beta.kubernetes.io/os` is deprecated since 1.14.

Message printed by kubectl:

```
W0714 15:21:21.896079 2914669 warnings.go:70] spec.template.spec.nodeSelector[beta.kubernetes.io/os]: deprecated since v1.14; use "kubernetes.io/os" instead
```

@hvaghani221 hvaghani221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sorry for the late review.

@hvaghani221
hvaghani221 merged commit 1334c4a into splunk:develop Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants