Repository navigation
QueryDSL support. - #1330
QueryDSL support.#1330
Conversation
17bd375 to
5a8d65c
Compare
d4a3910 to
faeb781
Compare
| @BeforeAll | ||
| static public void beforeAll() { | ||
| callSuperBeforeAll(new Object() {}); | ||
| ApplicationContext ac = new AnnotationConfigApplicationContext( |
There was a problem hiding this comment.
is that class also formatted with the spring data formatter? looks odd
| } | ||
|
|
||
| // this gives hqCountry == "" and hqCountry is missing | ||
| // @Test |
There was a problem hiding this comment.
why is this test commented out?
| } | ||
|
|
||
| protected DBRef asReference(Object constant, Path<?> path) { | ||
| return null; // converter.toDBRef(constant, getPropertyForPotentialDbRef(path)); |
There was a problem hiding this comment.
should this throw an unsupported op or something instead of returning null? (not sure how the comment relates)
There was a problem hiding this comment.
The commented out is from the mongo implementation. Our converter does not have a toDBRef (or similar) method. I don't think it is ever used.
I changed this to throw an RuntimeException.
| * CouchbaseDocumentSerializer#toSort(List) | ||
| */ | ||
| protected Sort createSort(List<OrderSpecifier<?>> orderSpecifiers) { | ||
| return null; // TODO serializer.toSort(orderSpecifiers); |
faeb781 to
a37722a
Compare
mp911de
left a comment
There was a problem hiding this comment.
Not sure how well the MongoDB serializer fits into Couchbase. I thought that translating Querydsl predicates into N1QL would be the way to go. Left a few dependency and code style comments.
| <dependency> | ||
| <groupId>com.querydsl</groupId> | ||
| <artifactId>querydsl-apt</artifactId> | ||
| <version>${querydsl}</version> |
There was a problem hiding this comment.
Should be <scope>provided</scope> to avoid mandatory dependencies on the annotation processor.
There was a problem hiding this comment.
added scope provided
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> |
There was a problem hiding this comment.
Buildhelper should actually not be necessary.
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> | ||
| <version>${javax-annotation-api}</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
Should actually remain in test scope. Probably a consequence of how the generated sources are mounted into the project.
There was a problem hiding this comment.
restored scope test.
| // (powered by FernFlower decompiler) | ||
| // | ||
|
|
||
| package com.querydsl.couchbase; |
There was a problem hiding this comment.
Oops. This file doesn't belong in the commit.
| import org.jetbrains.annotations.Nullable; | ||
| import org.springframework.data.couchbase.core.mapping.CouchbaseDocument; | ||
|
|
||
| public abstract class AbstractCouchbaseQuery<K, Q extends AbstractCouchbaseQuery<K, Q>> implements SimpleQuery<Q>, Fetchable<K> { |
There was a problem hiding this comment.
The formatting of this file is off.
a37722a to
c41d710
Compare
Closes #1288.
c41d710 to
3c9b7f5
Compare
Closes #1288.