Skip to content

Observability with Micrometer & Micrometer Tracing - #3942

Closed
marcingrzejszczak wants to merge 21 commits into
spring-projects:4.0.xfrom
marcingrzejszczak:observability
Closed

marcingrzejszczak wants to merge 21 commits into
spring-projects:4.0.xfrom
marcingrzejszczak:observability

Conversation

@marcingrzejszczak

Copy link
Copy Markdown
Contributor

No description provided.

christophstrobl and others added 11 commits January 13, 2022 15:47
Upgrade to data-commons 3.0 and Java 17 (still source level 16 due to asm).
Remove support for threeten, joda-time.
Transition to PersistentEntitiesFactoryBean from data-commons.
Update build to MongoDB 4.4 and 5 with Java17. Remove Java8 setup.
Fix javadoc tooling error on cdi 1 vs. 2 version mix.
Disabled internal package cycle analysis as this requires transition to ArchUnit.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 19, 2022
@mp911de

mp911de commented Jan 20, 2022

Copy link
Copy Markdown
Member

We should add an integration test (is there a mock Tracer implementation) and a bit of documentation regarding the tracing integration.

@gregturn

gregturn commented Jan 21, 2022 •

Copy link
Copy Markdown
Contributor

Where does MongoTracingRecordingHandler get wired into everything? I don't see an instance created anywhere but inside test cases. Is the idea that Spring Boot will autowire that?

@marcingrzejszczak

Copy link
Copy Markdown
Contributor Author

Yes, it will be injected into micrometer#config#timerRecordingHandlers

@marcingrzejszczak
marcingrzejszczak marked this pull request as ready for review January 26, 2022 17:09
@marcingrzejszczak

Copy link
Copy Markdown
Contributor Author

I've updated the code to use the enum based approach to describe metrics and spans. I've added automated docs generation from those sources the outcome of which would be the following doc

image

gregturn added a commit that referenced this pull request Feb 16, 2022
gregturn pushed a commit that referenced this pull request Feb 16, 2022
gregturn added a commit that referenced this pull request Feb 17, 2022
@gregturn gregturn closed this Feb 18, 2022
@gregturn

Copy link
Copy Markdown
Contributor

Resolved via 4c77763

@mp911de mp911de added this to the 4.0 M4 (2022.0.0) milestone Mar 30, 2022
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants