You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove @Configuration meta-annotation from @Enable annotations #6613
Currently, all Spring Security's @Enable annotations are meta-annotated with @Configuration. While convenient, this is not consistent with the rest of the Spring projects and most notably Spring Framework's @Enable annotations.
Additionally, the introduction of support for @Configuration(proxyBeanMethods=false) in Spring Framework provides a compelling reason to remove @Configuration meta-annotation from Spring Security's @Enable annotations and allow users to opt into their preferred configuration mode.
It's yours @jsattler! Keep in mind we'll want to update the reference documentation, javadoc and samples. I'll open a ticket to update the samples, and if you don't feel you can tackle that part just let me know.
@sjohnr I will take care of the reference documentation, javadoc and samples. The actual removal of the @Configuration from the @Enable* annotations will be tackled in a separate PR, as this seems to be a breaking change, correct? If it is tackled in a separate PR should I anyhow already update the tests using only @Enable*?
@jsattler yes, please do update tests if necessary! I think it can be done under this issue, but if you would like a separate issue let me know. And yes, this is a breaking change so I believe it will only be done in 6.0 (main). @rwinch can correct me if I'm wrong.
Activity
sjohnr commentedon Jul 26, 2022
Note that we will want to update the documentation examples to include
@Configurationin places where it's currently missing.jsattler commentedon Jul 27, 2022
@sjohnr I would like to help on this, as I was anyhow looking into the documentation part.
sjohnr commentedon Jul 27, 2022
It's yours @jsattler! Keep in mind we'll want to update the reference documentation, javadoc and samples. I'll open a ticket to update the samples, and if you don't feel you can tackle that part just let me know.
jsattler commentedon Jul 27, 2022
@sjohnr I will take care of the reference documentation, javadoc and samples. The actual removal of the
@Configurationfrom the@Enable*annotations will be tackled in a separate PR, as this seems to be a breaking change, correct? If it is tackled in a separate PR should I anyhow already update the tests using only@Enable*?sjohnr commentedon Jul 29, 2022
@jsattler yes, please do update tests if necessary! I think it can be done under this issue, but if you would like a separate issue let me know. And yes, this is a breaking change so I believe it will only be done in 6.0 (
main). @rwinch can correct me if I'm wrong.Remove Configuration meta-annotation from Enable* annotations
Remove Configuration meta-annotation from Enable* annotations
Remove Configuration meta-annotation from Enable* annotations
jsattler commentedon Jul 30, 2022
Quite some files changed, hope that's okay for a single PR. If you have any suggestions to split this up, please let me know.
rwinch commentedon Aug 9, 2022
A note for self. I used the following to check for missing
@Configuration:Then run
Fix Add @configuration to @enable*Security Usage
rwinch commentedon Aug 9, 2022
Closing in favor of gh-11653
Add @configuration
Bump version of dependencies (#2466)