Skip to content

fix: prevent TOCTOU in requirements file reads - #2119

Merged
kemingy merged 1 commit into
tensorchord:mainfrom
kemingy:root_read_file
Oct 2, 2026
Merged

kemingy merged 1 commit into
tensorchord:mainfrom
kemingy:root_read_file

Conversation

@kemingy

@kemingy kemingy commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Open requirements files through os.OpenRoot and Root.Open so containment is enforced during filesystem traversal. Resolving symlinks before os.Open left a race between validation and use.

Ref: https://go.dev/blog/osroot

Open requirements files through os.OpenRoot and Root.Open so
containment is enforced during filesystem traversal. Resolving
symlinks before os.Open left a race between validation and use.

Signed-off-by: Keming <kemingy94@gmail.com>
@kemingy
kemingy requested a review from zwpaper as a code owner October 2, 2026 07:24
@kemingy
kemingy merged commit 9d575b3 into tensorchord:main Oct 2, 2026
11 checks passed
@kemingy
kemingy deleted the root_read_file branch October 2, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant