Repository navigation
fix: Add back DecodeError::new - #1382
Merged
Merged
Conversation
This function was meant for internal use only. Because of `doc(hidden)` it was publicly available and it is actually used by users. The prost 0.14.2 release broken some of the crate ecosystem. That release was yanked. To prevent more breakage, this PR adds the function back. This time as a public function that is documented to not be used. The prost project intents to remove this function in the next breaking release.
caspermeijn
force-pushed
the
decode_error_new
branch
from
December 15, 2025 08:15
1f768da to
09a8832
Compare
Contributor
|
This LGTM. Can you share the commit in which this was removed for more context? |
jknovi
approved these changes
Jan 7, 2026
Member
LucioFranco
reviewed
Jan 10, 2026
|
It seems unfortunate if Is there a plan to provide a public interface for creawting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was meant for internal use only. Because of
doc(hidden)it was publicly available and it is actually used by users. The prost 0.14.2 release broken some of the crate ecosystem. That release was yanked. To prevent more breakage, this PR adds the function back. This time as a public function that is documented to not be used.The prost project intents to remove this function in the next breaking release.