Repository navigation
analyzer/github: include is_fine_grained metadata and make gist enumeration non-fatal - #5332
Merged
Merged
Conversation
Add the FineGrained boolean (already present on TokenMetadata) to the metadata map in secretInfoToAnalyzerResult. Update both test fixtures to include the new field. Co-authored-by: Cursor <cursoragent@cursor.com>
Change both AnalyzeClassicToken and AnalyzeFineGrainedToken to continue with an empty gists slice when GetAllGistsForUser fails, instead of aborting. Gists are supplemental resources; the core result (metadata, repos, permissions) is fully usable without them. Co-authored-by: Cursor <cursoragent@cursor.com>
shahzadhaider1
approved these changes
Sep 21, 2026
mariduv
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Two fixes for the GitHub PAT analyzer:
Include
is_fine_grainedin analyzer metadata.secretInfoToAnalyzerResultbuilds the metadata map that downstream consumers use, but it never included theFineGrainedboolean despite it being available onTokenMetadata. Consumers that branch onis_fine_grainedto select the correct permission catalog (classic vs fine-grained) always fell back to classic. This adds the field and updates both test fixtures.Make gist enumeration non-fatal. Both
AnalyzeClassicTokenandAnalyzeFineGrainedTokencallGetAllGistsForUserand treat any error as fatal, discarding all already-gathered metadata, repos, and permissions. Gists are supplemental resources — if enumeration fails (e.g. rate-limit), the core analysis result is still fully usable. The error handling now continues with an empty gists slice instead of aborting.Checklist:
make test-community)?make lintthis requires golangci-lint)?Made with Cursor