Repository navigation
fix(Combobox): search term not reactive to prop changes - #1863
Merged
zernonia merged 1 commit intoMay 5, 2025
Merged
Conversation
If the `ComboboxInput` `modelValue` prop was changed, then the `filterState.search` was not updated, so the previously filtered results were still shown in the combobox content. With this change, we explicitly update the `filterState.search` whenever the `modelValue` is updated.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
ComboboxInputmodelValueprop was changed, then thefilterState.searchwas not updated, so the previously filtered results were still shown in the combobox content.With this change, we explicitly update the
filterState.searchwhenever themodelValueis updated.To test this, I added this snippet to the
ComboboxBasic.story.vue, and addedv-model="searchTerm"prop to theComboboxInputcomponent:and can see that the list is not filtered whenever the search term is changed:
Screen.Recording.2025-04-30.at.09.57.42.mov
However, after applying this fix, the list is filtered as expected:
Screen.Recording.2025-04-30.at.09.58.30.mov