Repository navigation
Don't panic in overflowing Timestamp to SystemTime conversion - #909
Merged
Merged
Conversation
1 task
kodiakhq Bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Sep 14, 2026
Bumps uuid from 1.26.0 to 1.26.1. Release notes Sourced from uuid's releases. v1.26.1 What's Changed Seat the v7 counter below the version nibble by @lenamonj in uuid-rs/uuid#907 Don't panic in overflowing Timestamp to SystemTime conversion by @KodrAus in uuid-rs/uuid#909 Prepare for 1.26.1 release by @KodrAus in uuid-rs/uuid#910 New Contributors @lenamonj made their first contribution in uuid-rs/uuid#907 Full Changelog: uuid-rs/uuid@v1.26.0...v1.26.1 Commits 9f92712 Merge pull request #910 from uuid-rs/cargo/v1.26.1 d4df8f0 prepare for 1.26.1 release 5613f23 Merge pull request #909 from uuid-rs/fix/ts-conversion-overflow fda00eb don't panic in overflowing Timestamp to SystemTime conversion c82e88c Merge pull request #907 from lenamonj/v7-counter-placement ac065a6 Align the counter diagram 34ec102 Seat the v7 counter below the version nibble See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
youdie006
added a commit
to youdie006/uuid-rs-uuid
that referenced
this pull request
Sep 15, 2026
uuid-rs#909 wrapped the SystemTime add in checked_add, but Duration::new panics first when subsec_nanos carries past u64::MAX seconds, so SystemTime::from(Timestamp::from_unix_time(u64::MAX, 1_000_000_000, 0, 0)) still aborts. Build the Duration from its parts with checked arithmetic so both steps are guarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #908
We don't have any stable APIs available to us to saturate if conversion would overflow, so we just need to pick something we do have.