Repository navigation
fix: remove restoreFieldSource from FormAIController (#10099) (CP: 25.3) - #10120
Merged
Merged
Conversation
## Description Fixes #10078 Making the method also mark the field was considered and rejected. The value from before the fill is not part of the restored data, so the revert control would have had nothing to restore, and applications without source tracking would still have had no way to bring a mark back at all. - Removed `restoreFieldSource(HasValue, ValueSource)` from `FormAIController`, along with its tests and Javadoc mentions - A form rebuilt from application data loses its field marks together with the sources, and only the source could be put back, so a restored value looked like user input with nothing to show for the restore. Restoring sources and marks will be designed as one round trip, together with an API for putting marks back. - Changed `AIFieldMarkerPage` to write the quantity field through the `fill_form` tool with a source envelope, the way a real fill reports a source ## Type of change - Bugfix > [!NOTE] > The method shipped in the 25.3 betas, so this needs a pick to the 25.3 branch before GA. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
tomivirkki
approved these changes
Sep 14, 2026
tomivirkki
enabled auto-merge (squash)
September 14, 2026 12:04
|
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.3.0-rc1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR cherry-picks changes from the original PR #10099 to branch 25.3.
Original PR description