Repository navigation
feat: add select all button to MultiSelectComboBox - #10208
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
web-padawan
reviewed
Sep 24, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
web-padawan
reviewed
Sep 24, 2026
sissbruecker
force-pushed
the
feat/mscb-select-all
branch
from
September 24, 2026 07:50
3d48b11 to
64da5f9
Compare
web-padawan
approved these changes
Sep 24, 2026
|
This was referenced Sep 24, 2026
This was referenced Sep 24, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Part of vaadin/web-components#4590
setSelectAllButtonVisible(boolean)toMultiSelectComboBoxfor showing a select all button in the dropdown. The button is only supported with in-memory data providers. With a lazy data provider, the button is hidden and a warning is logged._allSelectedproperty:_toggleSelectAllHandler, which calls thetoggleSelectAll()client callable_allSelected, while that property is set_allSelectedby fetching the filtered items from the data provider. With client-side filtering, it removes the property, so the web component falls back to local handling._allSelectedis updated in aBeforeClientResponseActionafter value changes, filter changes, data resets and data provider changesKnown Gaps
Type of change